From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KuTzc-0006Xr-HG for qemu-devel@nongnu.org; Mon, 27 Oct 2008 11:26:56 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KuTza-0006WW-2y for qemu-devel@nongnu.org; Mon, 27 Oct 2008 11:26:55 -0400 Received: from [199.232.76.173] (port=43484 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KuTzZ-0006WT-L1 for qemu-devel@nongnu.org; Mon, 27 Oct 2008 11:26:53 -0400 Received: from lizzard.sbs.de ([194.138.37.39]:19553) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KuTzZ-0002HR-EE for qemu-devel@nongnu.org; Mon, 27 Oct 2008 11:26:53 -0400 Received: from mail1.sbs.de (localhost [127.0.0.1]) by lizzard.sbs.de (8.12.11.20060308/8.12.11) with ESMTP id m9RFQmYG020890 for ; Mon, 27 Oct 2008 16:26:49 +0100 Received: from [139.25.109.167] (mchn012c.mchp.siemens.de [139.25.109.167] (may be forged)) by mail1.sbs.de (8.12.11.20060308/8.12.11) with ESMTP id m9RFQkEg015944 for ; Mon, 27 Oct 2008 16:26:48 +0100 Message-ID: <4905DDB7.5090409@siemens.com> Date: Mon, 27 Oct 2008 16:26:47 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <11d301c93090$7e06d290$7a1477b0$@com> <010f01c93810$47ccb500$d7661f00$@com> <4905C997.5060801@codemonkey.ws> <5d6222a80810270727l3a213a22yba93abb2a873a103@mail.gmail.com> In-Reply-To: <5d6222a80810270727l3a213a22yba93abb2a873a103@mail.gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: Preliminary patch to implement ehci Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Glauber Costa wrote: > On Mon, Oct 27, 2008 at 12:00 PM, Anthony Liguori wrote: >> Mark Burkley wrote: >>> Hi folks, >>> >>> Just checking, did anyone get a chance to look at this? >>> >>> Any suggestions for next steps? Should I post a patch against trunk? >>> >> Submitting the patch against 0.9.1 is a non-starter. 0.9.1 is at least a >> year old and the USB code has been majorly refactored. If you want people >> to review it, it has to be against trunk. >> >> Also make sure that you include a [PATCH] in your subject. Otherwise, it's >> easily missed on the list. > The chances of anyone reviewing a patch that big is also very small. > So please, split it in minor, self-contained patches so it make it > easier for reviewers. As this patch mostly adds a new implementation, I'm not sure if that request matches here. But I have two further remarks: - Ensure that your patch is not line-wrapped (maybe you have to switch your mail client, dunno if Outlook is "fixable") - Adopt your patch to the coding style you find in other qemu files (check at least two so that you don't accidentally pick a bad example ;) ) Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux