From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KuYzN-0001os-FT
	for qemu-devel@nongnu.org; Mon, 27 Oct 2008 16:47:01 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KuYzL-0001nt-Rk
	for qemu-devel@nongnu.org; Mon, 27 Oct 2008 16:47:01 -0400
Received: from [199.232.76.173] (port=51723 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KuYzL-0001nq-Lv
	for qemu-devel@nongnu.org; Mon, 27 Oct 2008 16:46:59 -0400
Received: from yw-out-1718.google.com ([74.125.46.155]:28725)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KuYzK-0000Xy-Pe
	for qemu-devel@nongnu.org; Mon, 27 Oct 2008 16:46:59 -0400
Received: by yw-out-1718.google.com with SMTP id 6so539370ywa.82
	for <qemu-devel@nongnu.org>; Mon, 27 Oct 2008 13:46:55 -0700 (PDT)
Message-ID: <490628BB.70406@codemonkey.ws>
Date: Mon, 27 Oct 2008 15:46:51 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/2] Move some declarations around in the
	QEMU CharDriver code
References: <1224790775-14106-1-git-send-email-aliguori@us.ibm.com>
	<f43fc5580810240712g73a2d6a5ue8959ce94f76a270@mail.gmail.com>
In-Reply-To: <f43fc5580810240712g73a2d6a5ue8959ce94f76a270@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Blue Swirl wrote:
> On 10/23/08, Anthony Liguori <aliguori@us.ibm.com> wrote:
>   
>> The goal of this series is to move the CharDriverState code out of vl.c and
>>  into its own file, qemu-char.c.  This patch moves around some declarations so
>>  the next patch can be pure code motion.
>>     
>
> Good idea. Do you plan to do this for other things, for example network code?
>   

Yes, I have patches in queue to move out the networking code, the timer 
code, and the main loop.  I have two goals here.  A lot of the vl.c code 
is target independent so I'd like to move a lot of that code to be 
compiled once for all targets.  I also want to be able to reuse the main 
loop in things like qemu-nbd so that it can be fully asychronous without 
needing to rewrite all of that code.

I'll go ahead and commit the CharDriverState movement and post the next 
movement patch in a couple days.

>   
>>  -static inline int send_all(int fd, const uint8_t *buf, int len1)
>>  +inline int send_all(int fd, const uint8_t *buf, int len1)
>>     
>
> The 'inline' looks a bit odd without 'static'.
>   

Yeah, I'll fix that.  Didn't notice that for whatever reason.

Regards,

Anthony Liguori