qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fabrice Bellard <fabrice@bellard.org>
To: gleb@redhat.com
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/6] Disable init of SMM.
Date: Tue, 28 Oct 2008 11:27:40 +0100	[thread overview]
Message-ID: <4906E91C.7090505@bellard.org> (raw)
In-Reply-To: <20081026144440.9145.61050.stgit@gleb-debian.qumranet.com.qumranet.com>

Can you explain why you disabled SMM ? The memory it uses is only mapped
if SMI is enabled, so the OS cannot normally use it.

Regards,

Fabrice.

Gleb Natapov wrote:
> SMM initialization uses memory available for OS use.
> 
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> ---
> 
>  bios/rombios32.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>  mode change 100644 => 100755 bios/rombios32.c
> 
> diff --git a/bios/rombios32.c b/bios/rombios32.c
> old mode 100644
> new mode 100755
> index ff84f80..e887d71
> --- a/bios/rombios32.c
> +++ b/bios/rombios32.c
> @@ -38,7 +38,7 @@ typedef unsigned long long uint64_t;
>  //#define BX_USE_EBDA_TABLES
>  
>  /* define it if the (emulated) hardware supports SMM mode */
> -#define BX_USE_SMM
> +//#define BX_USE_SMM
>  
>  #define cpuid(index, eax, ebx, ecx, edx) \
>    asm volatile ("cpuid" \
> 
> 
> 
> 

  reply	other threads:[~2008-10-28 10:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-26 14:44 [Qemu-devel] [PATCH 0/6] Support for S3 ACPI state (suspend to memory) in BIOS Gleb Natapov
2008-10-26 14:44 ` [Qemu-devel] [PATCH 1/6] Move PIC initialization out of line to save space in post code area Gleb Natapov
2008-10-26 14:44 ` [Qemu-devel] [PATCH 2/6] Add S3 state to DSDT. Handle resume event in the BIOS Gleb Natapov
2008-10-26 14:44 ` [Qemu-devel] [PATCH 3/6] Disable init of SMM Gleb Natapov
2008-10-28 10:27   ` Fabrice Bellard [this message]
2008-10-26 14:44 ` [Qemu-devel] [PATCH 4/6] Execute rombios32 code from rom address 0xe0000 Gleb Natapov
2008-10-26 14:44 ` [Qemu-devel] [PATCH 5/6] Don't use unreserved memory in BIOS Gleb Natapov
2008-10-26 14:44 ` [Qemu-devel] [PATCH 6/6] Don't power down vga card on entering S3 state Gleb Natapov
  -- strict thread matches above, loose matches on Subject: below --
2008-10-27 10:12 [Qemu-devel] [PATCH 0/6] Support for S3 ACPI state (suspend to memory) in BIOS Gleb Natapov
2008-10-27 10:13 ` [Qemu-devel] [PATCH 3/6] Disable init of SMM Gleb Natapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4906E91C.7090505@bellard.org \
    --to=fabrice@bellard.org \
    --cc=gleb@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).