From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Kuuhq-000554-Rb
	for qemu-devel@nongnu.org; Tue, 28 Oct 2008 15:58:22 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Kuuho-00054q-TE
	for qemu-devel@nongnu.org; Tue, 28 Oct 2008 15:58:22 -0400
Received: from [199.232.76.173] (port=52093 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Kuuho-00054n-ND
	for qemu-devel@nongnu.org; Tue, 28 Oct 2008 15:58:20 -0400
Received: from mx2.redhat.com ([66.187.237.31]:60197)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1Kuuho-0005U1-8J
	for qemu-devel@nongnu.org; Tue, 28 Oct 2008 15:58:20 -0400
Message-ID: <49076EC4.70909@redhat.com>
Date: Tue, 28 Oct 2008 20:57:56 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/4] sockets: switch vnc to new code, support
	vnc port auto-allocation.
References: <1225198518-16529-1-git-send-email-kraxel@redhat.com>	
	<1225198518-16529-4-git-send-email-kraxel@redhat.com>
	<f43fc5580810281025y2e6146d9hc72f0381a777fd01@mail.gmail.com>
In-Reply-To: <f43fc5580810281025y2e6146d9hc72f0381a777fd01@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org

Blue Swirl wrote:
> On 10/28/08, Gerd Hoffmann <kraxel@redhat.com> wrote:
>> This patch switches the vnc code ofer to the new socket helper
>>  functions.
>>  -    if (strcmp(display, "none") == 0)
>>  -       return 0;
>>  -
>>      if (!(vs->display = strdup(display)))
>>         return -1;
>>  +    if (strcmp(display, "none") == 0)
>>  +       return 0;
> 
> Why this change?

To keep vs->display and thus the "info vnc" output up-to-date.  Without
this you'll see stale information after "change vnc none".

> It looks like it will leak memory if display is "none".

Oops, yes.  Will fix.

cheers,
  Gerd