qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/4] Implement "info chardev" command.
Date: Tue, 28 Oct 2008 20:58:49 +0100	[thread overview]
Message-ID: <49076EF9.8040009@redhat.com> (raw)
In-Reply-To: <f43fc5580810281008u371b2180la8182d6943a3a4af@mail.gmail.com>

  Hi,

>>  @@ -55,9 +56,12 @@ struct CharDriverState {
>>      void *opaque;
>>      int focus;
>>      QEMUBH *bh;
>>  +    char *label;
>>  +    char *filename;
> 
> I think you should add 'const' to both above.

Will do.

thanks,
  Gerd

  reply	other threads:[~2008-10-28 19:59 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-28 12:55 [Qemu-devel] [PATCH 0/4] ipv6 and autoport patches Gerd Hoffmann
2008-10-28 12:55 ` [Qemu-devel] [PATCH 1/4] Implement "info chardev" command Gerd Hoffmann
2008-10-28 17:08   ` Blue Swirl
2008-10-28 19:58     ` Gerd Hoffmann [this message]
2008-10-29 11:02       ` Gerd Hoffmann
2008-10-29 18:30         ` Blue Swirl
2008-10-28 20:19   ` Daniel P. Berrange
2008-10-28 21:28     ` Gerd Hoffmann
2008-10-28 12:55 ` [Qemu-devel] [PATCH 2/4] sockets: helper functions for qemu Gerd Hoffmann
2008-10-28 13:15   ` Daniel P. Berrange
2008-10-28 14:22     ` Gerd Hoffmann
2008-10-28 14:31       ` Daniel P. Berrange
2008-10-28 15:10         ` Gerd Hoffmann
2008-10-28 12:55 ` [Qemu-devel] [PATCH 3/4] sockets: switch vnc to new code, support vnc port auto-allocation Gerd Hoffmann
2008-10-28 17:25   ` Blue Swirl
2008-10-28 19:57     ` Gerd Hoffmann
2008-10-29 10:46       ` Gerd Hoffmann
2008-10-28 12:55 ` [Qemu-devel] [PATCH 4/4] sockets: switch over tcp/telnet/unix serial line to new helper functions Gerd Hoffmann
2008-10-28 15:53 ` [Qemu-devel] [PATCH 0/4] ipv6 and autoport patches Anthony Liguori
  -- strict thread matches above, loose matches on Subject: below --
2008-10-31 12:47 [Qemu-devel] [PATCH v2 " Gerd Hoffmann
2008-10-31 12:47 ` [Qemu-devel] [PATCH 1/4] Implement "info chardev" command Gerd Hoffmann
2008-10-31 17:32   ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49076EF9.8040009@redhat.com \
    --to=kraxel@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).