From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KuuiU-0005Hp-SL
	for qemu-devel@nongnu.org; Tue, 28 Oct 2008 15:59:02 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KuuiT-0005HC-6X
	for qemu-devel@nongnu.org; Tue, 28 Oct 2008 15:59:02 -0400
Received: from [199.232.76.173] (port=52102 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KuuiS-0005H4-VD
	for qemu-devel@nongnu.org; Tue, 28 Oct 2008 15:59:01 -0400
Received: from mx2.redhat.com ([66.187.237.31]:60219)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1KuuiS-0005iD-Fc
	for qemu-devel@nongnu.org; Tue, 28 Oct 2008 15:59:00 -0400
Message-ID: <49076EF9.8040009@redhat.com>
Date: Tue, 28 Oct 2008 20:58:49 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/4] Implement "info chardev" command.
References: <1225198518-16529-1-git-send-email-kraxel@redhat.com>	
	<1225198518-16529-2-git-send-email-kraxel@redhat.com>
	<f43fc5580810281008u371b2180la8182d6943a3a4af@mail.gmail.com>
In-Reply-To: <f43fc5580810281008u371b2180la8182d6943a3a4af@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org

  Hi,

>>  @@ -55,9 +56,12 @@ struct CharDriverState {
>>      void *opaque;
>>      int focus;
>>      QEMUBH *bh;
>>  +    char *label;
>>  +    char *filename;
> 
> I think you should add 'const' to both above.

Will do.

thanks,
  Gerd