From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KuvvJ-0001GM-7x for qemu-devel@nongnu.org; Tue, 28 Oct 2008 17:16:21 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KuvvG-0001E4-EI for qemu-devel@nongnu.org; Tue, 28 Oct 2008 17:16:19 -0400 Received: from [199.232.76.173] (port=50828 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KuvvG-0001Do-5C for qemu-devel@nongnu.org; Tue, 28 Oct 2008 17:16:18 -0400 Received: from yx-out-1718.google.com ([74.125.44.155]:60522) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KuvvG-000569-Cp for qemu-devel@nongnu.org; Tue, 28 Oct 2008 17:16:18 -0400 Received: by yx-out-1718.google.com with SMTP id 3so651408yxi.82 for ; Tue, 28 Oct 2008 14:16:14 -0700 (PDT) Message-ID: <49078115.5070300@codemonkey.ws> Date: Tue, 28 Oct 2008 16:16:05 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 3/3] Add KVM support to QEMU References: <1225224814-9875-1-git-send-email-aliguori@us.ibm.com> <1225224814-9875-2-git-send-email-aliguori@us.ibm.com> <1225224814-9875-3-git-send-email-aliguori@us.ibm.com> <2C72FE46-AE54-48FB-8F6A-DA98D0A02DE1@web.de> <5d6222a80810281404h32b33ec0t10dd36ed4317244@mail.gmail.com> In-Reply-To: <5d6222a80810281404h32b33ec0t10dd36ed4317244@mail.gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori Glauber Costa wrote: > On Tue, Oct 28, 2008 at 6:57 PM, Andreas Färber wrote: > >> Anthony, >> >> Am 28.10.2008 um 21:13 schrieb Anthony Liguori: >> >> >>> diff --git a/kvm-all.c b/kvm-all.c >>> new file mode 100644 >>> index 0000000..4379071 >>> --- /dev/null >>> +++ b/kvm-all.c >>> @@ -0,0 +1,377 @@ >>> +/* >>> + * QEMU KVM support >>> + * >>> + * Copyright IBM, Corp. 2008 >>> + * >>> + * Authors: >>> + * Anthony Liguori >>> + * >>> + * This work is licensed under the terms of the GNU GPL, version 2. See >>> + * the COPYING file in the top-level directory. >>> + * >>> + */ >>> >> Just wondering - since this is a new file of yours, would it make sense to >> use "version 2 or, at your option, any later version" to avoid the recent >> binutils GPL compatibility issues in the future? >> > > It's not that easy, because it is not exatly "a new file of yours". > It's obviously derived > Well, kvm-all.c really isn't. There are maybe a few snippets (mainly if clauses) that came from qemu-kvm but not enough to be considered derived IMHO. kvm.c on the other hand contains enough that I would think it is derived (and I preserved the original copyright from qemu-kvm-x86.c). At any rate, as I said previously, Avi should agree before changing the license of any of it. > from current kvm code. That said, libkvm.c is version 2, and qemu-kvm.c is v2+. > I'm not sure if there's any legal restriction on the final product > anthony should follow. > Ah, I missed the or-higher part in qemu-kvm.c. I'll update the next round of patches to reflect that. I don't care either way honestly, I just copied the copyright from somewhere else. Regards, Anthony Liguori >> Andreas >> >> >> >> >> > > > >