From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kv7ks-0002DD-M1 for qemu-devel@nongnu.org; Wed, 29 Oct 2008 05:54:22 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kv7kq-0002BF-A5 for qemu-devel@nongnu.org; Wed, 29 Oct 2008 05:54:21 -0400 Received: from [199.232.76.173] (port=59511 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kv7kp-0002B4-Tr for qemu-devel@nongnu.org; Wed, 29 Oct 2008 05:54:20 -0400 Received: from mx2.redhat.com ([66.187.237.31]:46683) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kv7kp-00073C-Cc for qemu-devel@nongnu.org; Wed, 29 Oct 2008 05:54:19 -0400 Message-ID: <490832C3.4060602@redhat.com> Date: Wed, 29 Oct 2008 11:54:11 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 3/3] Add KVM support to QEMU References: <1225224814-9875-1-git-send-email-aliguori@us.ibm.com> <1225224814-9875-2-git-send-email-aliguori@us.ibm.com> <1225224814-9875-3-git-send-email-aliguori@us.ibm.com> <49078707.5000109@redhat.com> <49078955.2090109@codemonkey.ws> <5d6222a80810281604g39708040kf710725dce6413dd@mail.gmail.com> <4907A1FA.2060106@codemonkey.ws> In-Reply-To: <4907A1FA.2060106@codemonkey.ws> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Glauber Costa , Glauber Costa , qemu-devel@nongnu.org, kvm-devel , Gerd Hoffmann Anthony Liguori wrote: > Another place "hook" is updating a slot's dirty bitmap. Right now, > with my patchset we don't have live migration or the VGA RAM > optimization. There's nothing about the VGA RAM optimization that > wouldn't work for QEMU. I'm not sure that it really is an > optimization in the context of TCG, but I certainly don't think it's > any worse. The only thing you really need is to query the KVM dirty > bitmap when it comes time to enable start over querying the VGA dirty > bits. I don't understand this. The VGA optimization really is qemu's, the kvm modifications only cater to the different way of getting the dirty bits. > The same is needed for live migration, so I think what we really need > is to change the memory dirty bit tracking API to have a concept of > refresh that we can use to hook for KVM. > Can you elaborate on this refresh? -- error compiling committee.c: too many arguments to function