From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Kv8Zy-0003va-MI
	for qemu-devel@nongnu.org; Wed, 29 Oct 2008 06:47:10 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Kv8Zv-0003uC-Cr
	for qemu-devel@nongnu.org; Wed, 29 Oct 2008 06:47:09 -0400
Received: from [199.232.76.173] (port=56105 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Kv8Zu-0003tv-GA
	for qemu-devel@nongnu.org; Wed, 29 Oct 2008 06:47:06 -0400
Received: from mx2.redhat.com ([66.187.237.31]:51404)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1Kv8Zs-0002zL-Is
	for qemu-devel@nongnu.org; Wed, 29 Oct 2008 06:47:06 -0400
Message-ID: <49083F22.8070006@redhat.com>
Date: Wed, 29 Oct 2008 11:46:58 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/4] sockets: switch vnc to new code, support
	vnc port auto-allocation.
References: <1225198518-16529-1-git-send-email-kraxel@redhat.com>		<1225198518-16529-4-git-send-email-kraxel@redhat.com>	<f43fc5580810281025y2e6146d9hc72f0381a777fd01@mail.gmail.com>
	<49076EC4.70909@redhat.com>
In-Reply-To: <49076EC4.70909@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>

Gerd Hoffmann wrote:
> Blue Swirl wrote:
>> On 10/28/08, Gerd Hoffmann <kraxel@redhat.com> wrote:
>>> This patch switches the vnc code ofer to the new socket helper
>>>  functions.
>>>  -    if (strcmp(display, "none") == 0)
>>>  -       return 0;
>>>  -
>>>      if (!(vs->display = strdup(display)))
>>>         return -1;
>>>  +    if (strcmp(display, "none") == 0)
>>>  +       return 0;
>> Why this change?
> 
> To keep vs->display and thus the "info vnc" output up-to-date.  Without
> this you'll see stale information after "change vnc none".

Scratch that.  vs->display is released and set to NULL in
vnc_display_close().  So this chunk isn't needed at all, I'll drop it.

cheers,
  Gerd