From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KvGIn-0000tj-Ex for qemu-devel@nongnu.org; Wed, 29 Oct 2008 15:01:57 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KvGIm-0000tE-Om for qemu-devel@nongnu.org; Wed, 29 Oct 2008 15:01:57 -0400 Received: from [199.232.76.173] (port=55295 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KvGIm-0000t2-LJ for qemu-devel@nongnu.org; Wed, 29 Oct 2008 15:01:56 -0400 Received: from e38.co.us.ibm.com ([32.97.110.159]:47960) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KvGIl-0007RI-Sb for qemu-devel@nongnu.org; Wed, 29 Oct 2008 15:01:56 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e38.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id m9TJ19E6026121 for ; Wed, 29 Oct 2008 13:01:09 -0600 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id m9TJ1rRJ095020 for ; Wed, 29 Oct 2008 13:01:53 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m9TJ1qbR010124 for ; Wed, 29 Oct 2008 13:01:52 -0600 Message-ID: <4908B314.1030703@us.ibm.com> Date: Wed, 29 Oct 2008 14:01:40 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1225224814-9875-1-git-send-email-aliguori@us.ibm.com> <1225224814-9875-2-git-send-email-aliguori@us.ibm.com> <1225224814-9875-3-git-send-email-aliguori@us.ibm.com> <20081029174122.GE11532@poweredge.glommer> In-Reply-To: <20081029174122.GE11532@poweredge.glommer> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 3/3] Add KVM support to QEMU Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: qemu-devel@nongnu.org, kvm-devel , Avi Kivity Glauber Costa wrote: > resending, now with less quoted text: > Yeah, I was intending to scold you about that ;-) >> diff --git a/kvm-all.c b/kvm-all.c >> new file mode 100644 >> index 0000000..4379071 >> --- /dev/null >> +++ b/kvm-all.c >> @@ -0,0 +1,377 @@ >> +/* >> + * QEMU KVM support >> + * >> + * Copyright IBM, Corp. 2008 >> + * >> + * Authors: >> + * Anthony Liguori >> + * >> + * This work is licensed under the terms of the GNU GPL, version 2. See >> + * the COPYING file in the top-level directory. >> + * >> + */ >> + >> +#include >> +#include >> +#include >> + >> +#include >> + >> +#include "qemu-common.h" >> +#include "sysemu.h" >> +#include "kvm.h" >> + >> +//#define DEBUG_KVM >> + >> +#ifdef DEBUG_KVM >> +#define dprintf(fmt, ...) \ >> + do { fprintf(stderr, fmt, ## __VA_ARGS__); } while (0) >> +#else >> +#define dprintf(fmt, ...) \ >> + do { } while (0) >> +#endif >> + >> +typedef struct kvm_userspace_memory_region KVMSlot; >> > > Actually, I don't think it is a good idea. > We may want to keep internal-only data tied to the slot, such the slot's > dirty bitmap if we do per-slot dirty tracking. > > Of course there may be other ways to do it, but this is the cleaner > and more adequate since we're going through a fresh start. > For now, I think it's fine. Switching to making it a proper structure is certainly a good idea when we get more stuff per slot. Regards, Anthony Liguori