From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Kvb9X-00021I-OC
	for qemu-devel@nongnu.org; Thu, 30 Oct 2008 13:17:47 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Kvb9U-0001xZ-2I
	for qemu-devel@nongnu.org; Thu, 30 Oct 2008 13:17:46 -0400
Received: from [199.232.76.173] (port=50183 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Kvb9T-0001xD-TN
	for qemu-devel@nongnu.org; Thu, 30 Oct 2008 13:17:43 -0400
Received: from yw-out-1718.google.com ([74.125.46.158]:63332)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Kvb9U-0005Zn-AX
	for qemu-devel@nongnu.org; Thu, 30 Oct 2008 13:17:44 -0400
Received: by yw-out-1718.google.com with SMTP id 6so274890ywa.82
	for <qemu-devel@nongnu.org>; Thu, 30 Oct 2008 10:17:41 -0700 (PDT)
Message-ID: <4909EC32.1090504@codemonkey.ws>
Date: Thu, 30 Oct 2008 12:17:38 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Preliminary patch to implement ehci
References: <E1KqsdV-0000r9-5B@monty-python.gnu.org>	<11d301c93090$7e06d290$7a1477b0$@com>	<010f01c93810$47ccb500$d7661f00$@com>	<4905C997.5060801@codemonkey.ws>
	<01d701c93aae$af7487a0$0e5d96e0$@com>
In-Reply-To: <01d701c93aae$af7487a0$0e5d96e0$@com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, Max Krasnyansky <maxk@kernel.org>

Mark Burkley wrote:
> Hi Anthony,
>
> I have ehci built against trunk now but I am seeing an issue with a memory
> key I am using for testing.  ioctl returns EPIPE (which I would have thought
> was a STALL) to an asynchronous IN completion in usb-linux.c but then this
> is returned as USB_RET_NAK to EHCI which confuses my WinXP target because
> the transfer is then never completed.
>
> Can I just check that it was intentional to return NAK for EPIPE returns in
> asynchronous completions?  If so, then I will try to detect the stall in my
> implementation and treat differently to a NAK.  It's just that if I modify
> usb-linux.c to return USB_RET_STALL on -EPIPE then it works fine.
>   

Max?

Regards,

Anthony Liguori

> Thanks,
>
> Mark
>