From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KvxrW-0003FO-SA for qemu-devel@nongnu.org; Fri, 31 Oct 2008 13:32:42 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KvxrV-0003FB-Qr for qemu-devel@nongnu.org; Fri, 31 Oct 2008 13:32:42 -0400 Received: from [199.232.76.173] (port=45396 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KvxrV-0003F8-Kz for qemu-devel@nongnu.org; Fri, 31 Oct 2008 13:32:41 -0400 Received: from rn-out-0910.google.com ([64.233.170.186]:25903) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KvxrV-0006r0-CT for qemu-devel@nongnu.org; Fri, 31 Oct 2008 13:32:41 -0400 Received: by rn-out-0910.google.com with SMTP id m61so1146051rnd.8 for ; Fri, 31 Oct 2008 10:32:40 -0700 (PDT) Message-ID: <490B4133.2030409@codemonkey.ws> Date: Fri, 31 Oct 2008 12:32:35 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/4] Implement "info chardev" command. References: <1225457254-1000-1-git-send-email-kraxel@redhat.com> <1225457254-1000-2-git-send-email-kraxel@redhat.com> In-Reply-To: <1225457254-1000-2-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann Gerd Hoffmann wrote: > This patch makes qemu keep track of the character devices in use and > implements a "info chardev" monitor command to print a list. > > qemu_chr_open() sticks the devices into a linked list now. It got a new > argument (label), so there is a name for each device. It also assigns a > filename to each character device. By default it just copyes the > filename passed in. Individual drivers can fill in something else > though. qemu_chr_open_pty() sets the filename to name of the pseudo tty > allocated. > > Output looks like this: > > (qemu) info chardev > monitor: filename=unix:/tmp/run.sh-26827/monitor,server,nowait > serial0: filename=unix:/tmp/run.sh-26827/console,server > serial1: filename=pty:/dev/pts/5 > parallel0: filename=vc:640x480 > > Signed-off-by: Gerd Hoffmann > Applied. Thanks. Regards, Anthony Liguori