From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KvyGw-0004L6-00 for qemu-devel@nongnu.org; Fri, 31 Oct 2008 13:58:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KvyGu-0004Jx-Gp for qemu-devel@nongnu.org; Fri, 31 Oct 2008 13:58:57 -0400 Received: from [199.232.76.173] (port=45973 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KvyGu-0004Ju-BA for qemu-devel@nongnu.org; Fri, 31 Oct 2008 13:58:56 -0400 Received: from rn-out-0910.google.com ([64.233.170.184]:30917) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KvyGt-0004Lg-U5 for qemu-devel@nongnu.org; Fri, 31 Oct 2008 13:58:56 -0400 Received: by rn-out-0910.google.com with SMTP id m61so1160580rnd.8 for ; Fri, 31 Oct 2008 10:58:55 -0700 (PDT) Message-ID: <490B475A.4000902@codemonkey.ws> Date: Fri, 31 Oct 2008 12:58:50 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/4] sockets: helper functions for qemu. References: <1225457254-1000-1-git-send-email-kraxel@redhat.com> <1225457254-1000-3-git-send-email-kraxel@redhat.com> <490B424C.7060404@codemonkey.ws> <20081031175023.GM29492@redhat.com> In-Reply-To: <20081031175023.GM29492@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Gerd Hoffmann Daniel P. Berrange wrote: > On Fri, Oct 31, 2008 at 12:37:16PM -0500, Anthony Liguori wrote: > > Gerd's patch does 'do the right thing' for 90% of people - it uses the > AI_ADDRCONFIG flag. This means that the getaddrinfo() name lookup will > only return an IPv6 address if there is at least one NIC with IPv6 > configured, likewise only return an IPv4 address if there is at least > one NIC with IPv4 configured. There are still times when it is desirable > to restrict it to just IPv4 or just IPv6, regardless of your host NIC > config - mostly when needing to interact with other broken apps which are > not correctly IPv6 aware. Maybe it would be sufficient to just have it added > as a flag to the arg in question though, eg -serial tcp:localhost:123,ipv4 > rather than a global -ipv4 flag > Yes, this would be much nicer. I think having the options as a global is likely to confuse users. Regards, Anthony Liguori > Daniel >