From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Kvz7v-0001VJ-RC
	for qemu-devel@nongnu.org; Fri, 31 Oct 2008 14:53:43 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Kvz7f-0001Ua-MK
	for qemu-devel@nongnu.org; Fri, 31 Oct 2008 14:53:43 -0400
Received: from [199.232.76.173] (port=51488 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Kvz7f-0001UX-Gn
	for qemu-devel@nongnu.org; Fri, 31 Oct 2008 14:53:27 -0400
Received: from yw-out-1718.google.com ([74.125.46.152]:60871)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Kvz7d-0000UV-8b
	for qemu-devel@nongnu.org; Fri, 31 Oct 2008 14:53:27 -0400
Received: by yw-out-1718.google.com with SMTP id 6so569492ywa.82
	for <qemu-devel@nongnu.org>; Fri, 31 Oct 2008 11:52:52 -0700 (PDT)
Message-ID: <490B53F0.9040200@codemonkey.ws>
Date: Fri, 31 Oct 2008 13:52:32 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [5578] Increase default IO timeout from 10ms to
 5s
References: <E1Kvyv4-0007b4-A3@cvs.savannah.gnu.org>
In-Reply-To: <E1Kvyv4-0007b4-A3@cvs.savannah.gnu.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

If anyone notices a slow down, I'd check this revision.  There may be 
broken bits of code out there that depends on wake up rate.  I've done a 
fair bit of testing and haven't found any but you never know.

Regards,

Anthony Liguori

Anthony Liguori wrote:
> Revision: 5578
>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5578
> Author:   aliguori
> Date:     2008-10-31 18:40:25 +0000 (Fri, 31 Oct 2008)
>
> Log Message:
> -----------
> Increase default IO timeout from 10ms to 5s
>
> With the recent changes to the main loop, we no longer have unconditional
> polling.  This means we can now sleep in select() for much longer than we
> previously did.  This patch increases our select() sleep time from 10ms to 5s
> which is effectively unlimited since we're going to wake up sooner than that
> in almost all circumstances.
>
> With this patch, I see the number of wake-ups with an idle dynamic ticks guest
> drop from 80 per second to about 15 times per second.
>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>
> Modified Paths:
> --------------
>     trunk/vl.c
>
> Modified: trunk/vl.c
> ===================================================================
> --- trunk/vl.c	2008-10-31 18:07:17 UTC (rev 5577)
> +++ trunk/vl.c	2008-10-31 18:40:25 UTC (rev 5578)
> @@ -8182,7 +8182,7 @@
>                              timeout = 0;
>                      }
>                  } else {
> -                    timeout = 10;
> +                    timeout = 5000;
>                  }
>              } else {
>                  timeout = 0;
> @@ -8192,7 +8192,7 @@
>                  ret = EXCP_INTERRUPT;
>                  break;
>              }
> -            timeout = 10;
> +            timeout = 5000;
>          }
>  #ifdef CONFIG_PROFILER
>          ti = profile_getclock();
>
>
>
>
>