From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KwE7Z-00075e-Fl for qemu-devel@nongnu.org; Sat, 01 Nov 2008 06:54:21 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KwE7X-00074R-LV for qemu-devel@nongnu.org; Sat, 01 Nov 2008 06:54:21 -0400 Received: from [199.232.76.173] (port=35490 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KwE7X-00074G-Ck for qemu-devel@nongnu.org; Sat, 01 Nov 2008 06:54:19 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]:52457) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KwE7W-0001DA-TQ for qemu-devel@nongnu.org; Sat, 01 Nov 2008 06:54:19 -0400 Message-ID: <490C3548.1040903@web.de> Date: Sat, 01 Nov 2008 11:54:00 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1223892640-15545-13-git-send-email-kirill@shutemov.name> <1224225264-8483-1-git-send-email-kirill@shutemov.name> <1224225264-8483-2-git-send-email-kirill@shutemov.name> <490C2253.3020005@web.de> <20081101102723.GB26770@localhost.localdomain> In-Reply-To: <20081101102723.GB26770@localhost.localdomain> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig61E2317FD63D3281FE7B9640" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH] linux-user, x86: use target_mmap() to allocate idt, gdt and ldt tables Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Kirill A. Shutemov" Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig61E2317FD63D3281FE7B9640 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Kirill A. Shutemov wrote: > On Sat, Nov 01, 2008 at 10:33:07AM +0100, Jan Kiszka wrote: >> Kirill A. Shutemov wrote: >>> env->*dt.base should fits target address space, so we should use >>> target_mmap to allocate it. >> I just noticed that this bug is still unfixed upstream, was about to >> repost my corresponding patch [1], but then found this even nicer >> approach. Could someone please finally merge a fix? >> >> Kirill, do you also have a patch for the problem [2] addresses in your= >> queue? >=20 > No, I don't. But we also can use target_mmap(with my mmap_find_vma()) f= or > it, I guess. Can you provide any testcase to reproduce the bug? I don't have a testcase for this. I just came across it at the time this h2g usage caused a compiler warning. Laster on, this warning was papered over, but the bug remained though I reminded people a few times. We don't need special allocation here (that's what I originally thought as well), we just need a robust way of detecting the guest-host address conflict: http://article.gmane.org/gmane.comp.emulators.qemu/28381 Maybe you can go through my old series and pick up the bits that still make sense. The user emulation is not on my daily radar, so these things could be forgotten again if I have to track them. :-] Jan --------------enig61E2317FD63D3281FE7B9640 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkkMNUgACgkQniDOoMHTA+lDhACaAoS3D8Pdz/pqZ1pa8pJO9R09 DdkAn03neW0hLCTiEGdt6lsD9zj/xEuX =WQMV -----END PGP SIGNATURE----- --------------enig61E2317FD63D3281FE7B9640--