From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Kx7Ti-0006DS-8D
	for qemu-devel@nongnu.org; Mon, 03 Nov 2008 17:00:54 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Kx7Tf-00067T-TD
	for qemu-devel@nongnu.org; Mon, 03 Nov 2008 17:00:53 -0500
Received: from [199.232.76.173] (port=41124 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Kx7Tf-00067G-LA
	for qemu-devel@nongnu.org; Mon, 03 Nov 2008 17:00:51 -0500
Received: from qw-out-1920.google.com ([74.125.92.145]:38142)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Kx7Tf-0005Jd-Ar
	for qemu-devel@nongnu.org; Mon, 03 Nov 2008 17:00:51 -0500
Received: by qw-out-1920.google.com with SMTP id 5so1145682qwc.4
	for <qemu-devel@nongnu.org>; Mon, 03 Nov 2008 14:00:46 -0800 (PST)
Message-ID: <490F7489.6040403@codemonkey.ws>
Date: Mon, 03 Nov 2008 16:00:41 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <E1Kvyv4-0007b4-A3@cvs.savannah.gnu.org>	<490B53F0.9040200@codemonkey.ws>
	<490DFAA2.7040900@web.de>	<490F5942.6020100@codemonkey.ws>
	<490F60E4.1040304@web.de> <490F723E.7070308@web.de>
In-Reply-To: <490F723E.7070308@web.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [5578] Increase default IO timeout from 10ms to 5s
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel@nongnu.org

Jan Kiszka wrote:
> Jan Kiszka wrote:
>   
>
> There is a race between the alarm_timer firing SIGALRM and
> main_loop_wait reaching the safe harbor of select (with that infamous 5
> second timeout). If the signal comes when already blocked in select, it
> will properly resume the latter immediately. But if the timer fired
> BEFORE that point, host_alarm_handler will only set a flag that the host
> timer has fired, the actual rearming will be done AFTER return from
> select. Ooops....
>   

Ah, so before this was causing the timer to potentially come 10ms later 
than it should have.  I was hoping that this change would shake out this 
stuff :-)

> So, select should actually include the host timer as event. timerfd?
> Unfortunately a recent Linux-only feature :-/. I don't think we can
> rearm the timer from within the signal handler, at least not without
> running all the pending qemu timers. And that is surely not a signal
> handler job (qemu timer handler aren't thread-safe in general).
>
> Anyone any ideas? /me is thinking a bit more about it as well.
>   

host_alarm_handler should write to a file descriptor instead of setting 
a flag.  That file descriptor should then be select()'d on (just like we 
do for SIGUSR2 in block-raw-posix.c).

Regards,

Anthony Liguori

> Jan
>
>