From: Paolo Bonzini <pbonzini@redhat.com>
To: "Laurent Vivier" <laurent@vivier.eu>,
"Max Reitz" <mreitz@redhat.com>, "Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org, Qemu-block <qemu-block@nongnu.org>
Cc: Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PULL 5/5] m68k: add Virtual M68k Machine
Date: Fri, 19 Mar 2021 12:08:38 +0100 [thread overview]
Message-ID: <49100ad9-f3ef-0948-d558-8076782af4d6@redhat.com> (raw)
In-Reply-To: <42717291-e5ac-091b-1272-c997536728aa@vivier.eu>
On 19/03/21 11:51, Laurent Vivier wrote:
>> It would also make the patches that Laurent sent this morning unnecessary, and avoid the use of
>> aliases in the tests (so that it's clear what is tested).
>
> We don't test the virtio frontend, but the blockdev backend, so we don't care what we use here.
Sort of, see for example the iothreads which, with your patch, would not
be covered anymore on s390.
> Aliases simplify the code...
Aliases are not deprecated but... let's say despised, because of the
special casing they add. But yes, the code simplification from your
patch is hard to brush away.
So I agree, since you have already mostly written the patches let's just
complete them.
Paolo
next prev parent reply other threads:[~2021-03-19 11:10 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 20:42 [PULL 0/5] M68k for 6.0 patches Laurent Vivier
2021-03-15 20:42 ` [PULL 1/5] hw/char: add goldfish-tty Laurent Vivier
2021-03-15 20:42 ` [PULL 2/5] hw/intc: add goldfish-pic Laurent Vivier
2021-03-15 20:42 ` [PULL 3/5] m68k: add an interrupt controller Laurent Vivier
2021-03-15 20:42 ` [PULL 4/5] m68k: add a system controller Laurent Vivier
2021-03-15 20:42 ` [PULL 5/5] m68k: add Virtual M68k Machine Laurent Vivier
2021-03-18 9:19 ` Philippe Mathieu-Daudé
2021-03-18 9:52 ` Laurent Vivier
2021-03-18 10:02 ` Philippe Mathieu-Daudé
2021-03-18 10:06 ` Laurent Vivier
2021-03-18 10:35 ` Paolo Bonzini
2021-03-18 10:40 ` Peter Maydell
2021-03-18 10:45 ` Paolo Bonzini
2021-03-18 11:10 ` Peter Maydell
2021-03-18 11:20 ` Philippe Mathieu-Daudé
2021-03-18 15:36 ` Philippe Mathieu-Daudé
2021-03-18 15:51 ` Laurent Vivier
2021-03-18 15:56 ` Laurent Vivier
2021-03-18 16:25 ` Philippe Mathieu-Daudé
2021-03-18 17:28 ` Max Reitz
2021-03-19 6:32 ` Thomas Huth
2021-03-19 9:20 ` Max Reitz
2021-03-19 9:29 ` Paolo Bonzini
2021-03-19 10:51 ` Laurent Vivier
2021-03-19 11:08 ` Paolo Bonzini [this message]
2021-03-19 10:50 ` Laurent Vivier
2021-03-19 10:51 ` Max Reitz
2021-03-19 10:57 ` Max Reitz
2021-03-19 10:55 ` Thomas Huth
2021-03-18 16:50 ` Paolo Bonzini
2021-03-17 13:34 ` [PULL 0/5] M68k for 6.0 patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49100ad9-f3ef-0948-d558-8076782af4d6@redhat.com \
--to=pbonzini@redhat.com \
--cc=laurent@vivier.eu \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).