From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KxMUX-0003yT-Hm
	for qemu-devel@nongnu.org; Tue, 04 Nov 2008 09:02:45 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KxMUV-0003yA-5j
	for qemu-devel@nongnu.org; Tue, 04 Nov 2008 09:02:44 -0500
Received: from [199.232.76.173] (port=50591 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KxMUU-0003y7-IF
	for qemu-devel@nongnu.org; Tue, 04 Nov 2008 09:02:42 -0500
Received: from e4.ny.us.ibm.com ([32.97.182.144]:56400)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1KxMUU-0003mg-3l
	for qemu-devel@nongnu.org; Tue, 04 Nov 2008 09:02:42 -0500
Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234])
	by e4.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id mA4E2bUt014132
	for <qemu-devel@nongnu.org>; Tue, 4 Nov 2008 09:02:37 -0500
Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64])
	by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id
	mA4E2beK084524
	for <qemu-devel@nongnu.org>; Tue, 4 Nov 2008 09:02:37 -0500
Received: from d01av04.pok.ibm.com (loopback [127.0.0.1])
	by d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	mA4E2bPO025606
	for <qemu-devel@nongnu.org>; Tue, 4 Nov 2008 09:02:37 -0500
Message-ID: <491055F9.60802@us.ibm.com>
Date: Tue, 04 Nov 2008 08:02:33 -0600
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
References: <1225224814-9875-1-git-send-email-aliguori@us.ibm.com>
	<1225224814-9875-2-git-send-email-aliguori@us.ibm.com>
	<1225224814-9875-3-git-send-email-aliguori@us.ibm.com>
	<49104D1F.1020905@redhat.com>
In-Reply-To: <49104D1F.1020905@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 3/3] Add KVM support to QEMU
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Glauber Costa <glommer@redhat.com>, qemu-devel@nongnu.org, kvm-devel <kvm@vger.kernel.org>

Avi Kivity wrote:
>>
>> +8) Merge in additional changes in kvm-userspace tree
>>   
>
> One of the important changes is running with signal delivery disabled, 
> since that's particularly slow (requires save/restore of the floating 
> point state, for example).

I think we need the IO thread first.  We're slowly getting there

>> +
>> +typedef struct kvm_userspace_memory_region KVMSlot;
>>   
>
> KVMMemorySlot?

Sure.

>> +
>> +static KVMState *kvm_state;
>>   
>
> Why a pointer?

I would like to avoid having the global state to begin with.

>> +    if (ret < 0) {
>> +        dprintf("kvm_create_vcpu failed\n");
>>   
>
> showing errno would be nice.

Indeed.

>> +
>> +static void kvm_getput_reg(__u64 *kvm_reg, target_ulong *qemu_reg, 
>> int set)
>> +{
>> +    if (set)
>> +        *kvm_reg = *qemu_reg;
>> +    else
>> +        *qemu_reg = *kvm_reg;
>> +}
>>   
>
> Ugh.
>
> I think live migration is now broken, since kvm accesses will not 
> update the qemu dirty bitmap.

Eh?  I don't follow you here.

Regards,

Anthony Liguori