From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KxMt1-00072R-Rj for qemu-devel@nongnu.org; Tue, 04 Nov 2008 09:28:03 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KxMsy-00071k-Qu for qemu-devel@nongnu.org; Tue, 04 Nov 2008 09:28:02 -0500 Received: from [199.232.76.173] (port=47511 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KxMsy-00071b-LP for qemu-devel@nongnu.org; Tue, 04 Nov 2008 09:28:00 -0500 Received: from qw-out-1920.google.com ([74.125.92.148]:14374) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KxMsx-0007ai-Tx for qemu-devel@nongnu.org; Tue, 04 Nov 2008 09:28:00 -0500 Received: by qw-out-1920.google.com with SMTP id 5so1358885qwc.4 for ; Tue, 04 Nov 2008 06:27:55 -0800 (PST) Message-ID: <49105BE7.6030505@codemonkey.ws> Date: Tue, 04 Nov 2008 08:27:51 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Fix alarm_timer race with select References: <490FFF23.5020704@web.de> <49105704.9070708@codemonkey.ws> In-Reply-To: <49105704.9070708@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Anthony Liguori wrote: > Jan Kiszka wrote: > > Perhaps we should move the alarm timer check rearming out of the main > loop and into a qemu_set_fd_handler2() handler? And now that I think about it, I see no reason why the timer expiration checks couldn't be moved to the same handler. I'd have to look more closely at how that would interact with icount though. Regards, Anthony Liguori > Regards, > > Anthony Liguori