From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KxPrb-0001s9-Cf
	for qemu-devel@nongnu.org; Tue, 04 Nov 2008 12:38:47 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KxPrZ-0001r8-IS
	for qemu-devel@nongnu.org; Tue, 04 Nov 2008 12:38:46 -0500
Received: from [199.232.76.173] (port=54921 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KxPrZ-0001qp-8z
	for qemu-devel@nongnu.org; Tue, 04 Nov 2008 12:38:45 -0500
Received: from qw-out-1920.google.com ([74.125.92.147]:40523)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KxPrZ-0005NR-C7
	for qemu-devel@nongnu.org; Tue, 04 Nov 2008 12:38:45 -0500
Received: by qw-out-1920.google.com with SMTP id 5so1417588qwc.4
	for <qemu-devel@nongnu.org>; Tue, 04 Nov 2008 09:38:43 -0800 (PST)
Message-ID: <4910889E.1050200@codemonkey.ws>
Date: Tue, 04 Nov 2008 11:38:38 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH] Fix alarm_timer race with select
References: <490FFF23.5020704@web.de>
	<49105704.9070708@codemonkey.ws>	<49105BE7.6030505@codemonkey.ws>
	<49108333.6080807@web.de>
In-Reply-To: <49108333.6080807@web.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Jan Kiszka <jan.kiszka@web.de>

Jan Kiszka wrote:
> Anthony Liguori wrote:
>   
>> Anthony Liguori wrote:
>>     
>>> Jan Kiszka wrote:
>>>
>>> Perhaps we should move the alarm timer check rearming out of the main
>>> loop and into a qemu_set_fd_handler2() handler?
>>>       
>> And now that I think about it, I see no reason why the timer expiration
>> checks couldn't be moved to the same handler.  I'd have to look more
>> closely at how that would interact with icount though.
>>     
>
> I cannot yet follow you here. But I my impression is that this will be
> an additional change that should come in a separate patch, no?
>   

Yeah, I can take care of that.  This is general cleanup that I've wanted 
to do to the main loop.

> Find the O_NONBLOCK remark addressed below.
>   

Great!  I'll give it a spin.

Regards,

Anthony Liguori