From: Jan Kiszka <jan.kiszka@web.de>
To: Jamie Lokier <jamie@shareable.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH] Fix alarm_timer race with select
Date: Wed, 05 Nov 2008 14:01:49 +0100 [thread overview]
Message-ID: <4911993D.4030001@web.de> (raw)
In-Reply-To: <20081105123650.GE13630@shareable.org>
[-- Attachment #1: Type: text/plain, Size: 555 bytes --]
Jamie Lokier wrote:
> Jan Kiszka wrote:
>> + if (pipe(fds) || fcntl(fds[0], F_SETFL, O_NONBLOCK)
>> + || fcntl(fds[1], F_SETFL, O_NONBLOCK)) {
>
> Is this a portable way to set O_NONBLOCK on all host platforms?
> I'm under the impression you need to ues F_GETFL first, in case
> other flags are important to the functioning of the file descriptor.
[ Checking the spec ] That's likely true, read-modify-write is
recommended. Can changes this. Consequently, quite a few other spots in
qemu should then be changed as well...
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
prev parent reply other threads:[~2008-11-05 13:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-04 7:52 [Qemu-devel] [PATCH] Fix alarm_timer race with select Jan Kiszka
2008-11-04 14:07 ` Anthony Liguori
2008-11-04 14:27 ` Anthony Liguori
2008-11-04 17:15 ` [Qemu-devel] " Jan Kiszka
2008-11-04 17:38 ` Anthony Liguori
2008-11-04 19:16 ` Anthony Liguori
2008-11-04 19:37 ` Jan Kiszka
2008-11-05 12:36 ` Jamie Lokier
2008-11-05 13:01 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4911993D.4030001@web.de \
--to=jan.kiszka@web.de \
--cc=jamie@shareable.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).