From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: Possible bug in Qemu tcp migration
Date: Thu, 06 Nov 2008 10:16:53 -0600 [thread overview]
Message-ID: <49131875.9080500@codemonkey.ws> (raw)
In-Reply-To: <4913121A.3060004@redhat.com>
Chris Lalancette wrote:
> Anthony Liguori wrote:
>
>> Chris Lalancette wrote:
>>
>>> Anthony,
>>>
>>> If, instead, I add a 5 second sleep in between steps b. and c. on the source
>>> side, then the migration completes as expected. It seems that the "migrate"
>>> monitor command is actually returning before everything is complete, so killing
>>> off the guest on the source side makes the destination wait around forever.
>>> Unfortunately, I haven't yet had time to look at it in any detail to see what's
>>> going on in the Qemu side, but I thought I would give you a heads up, and maybe
>>> you have an idea of where to look.
>>>
>>>
>> Can you try the latest SVN? Specifically, r5640.
>>
>
> I took just that patch, applied it to my copy of KVM (KVM-78), and tried it out,
> and it seems to have done it. Thanks Anthony!
>
Good, I honestly don't understand why it works ;-)
Resuming the monitor should not allow monitor commands to execute until
you get to the main loop. I looked through the readline code and that
seems to confirm that, but perhaps you had sent monitor input already
and it was buffered? So that it was just awaiting the opportunity to
execute the command (no IO needed).
Regards,
Anthony Liguori
prev parent reply other threads:[~2008-11-06 16:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-06 15:04 [Qemu-devel] Possible bug in Qemu tcp migration Chris Lalancette
2008-11-06 15:24 ` [Qemu-devel] " Anthony Liguori
2008-11-06 15:30 ` Anthony Liguori
2008-11-06 15:49 ` Chris Lalancette
2008-11-06 16:16 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49131875.9080500@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).