From: Kevin Wolf <kwolf@suse.de>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <Laurent.Vivier@libertysurf.fr>
Subject: Re: [Qemu-devel] [PATCH 0/4] qcow2: Improve cluster refcount update
Date: Fri, 07 Nov 2008 09:31:30 +0100 [thread overview]
Message-ID: <4913FCE2.3010705@suse.de> (raw)
In-Reply-To: <49133D17.3050100@codemonkey.ws>
Anthony Liguori schrieb:
> Laurent Vivier wrote:
>> This series of patches improves qcow2 performance with O_DIRECT
>> when the qcow2 file is empty and we begin to fill it.
>>
>
> I really dislike this series and any future series that does similar
> things. The real problem is that non-aligned accesses are so slow, but
> there's no reason that they must be so slow. It's because we're doing
> synchronous IO operations instead of using posix-aio like we should.
> That's the real problem. Just doing a memory copy to an aligned buffer
> is not going to cause that much performance delay.
Even if you don't like the alignment part, patches 1 and 2 are still
useful, IMHO.
Kevin
next prev parent reply other threads:[~2008-11-07 8:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-06 16:55 [Qemu-devel] [PATCH 0/4] qcow2: Improve cluster refcount update Laurent Vivier
2008-11-06 18:53 ` Anthony Liguori
2008-11-07 8:31 ` Kevin Wolf [this message]
2008-11-07 8:44 ` Laurent Vivier
2008-11-07 13:59 ` Anthony Liguori
2008-11-07 15:01 ` Laurent Vivier
2008-11-07 15:37 ` Anthony Liguori
2008-11-07 15:48 ` Laurent Vivier
2008-11-09 14:35 ` Avi Kivity
2008-11-09 16:32 ` Anthony Liguori
2008-11-10 20:15 ` Andreas Färber
2008-11-10 20:52 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4913FCE2.3010705@suse.de \
--to=kwolf@suse.de \
--cc=Laurent.Vivier@libertysurf.fr \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).