From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KyRs9-0007r9-Ao for qemu-devel@nongnu.org; Fri, 07 Nov 2008 08:59:37 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KyRs7-0007pF-S0 for qemu-devel@nongnu.org; Fri, 07 Nov 2008 08:59:37 -0500 Received: from [199.232.76.173] (port=60458 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KyRs7-0007p6-Pi for qemu-devel@nongnu.org; Fri, 07 Nov 2008 08:59:35 -0500 Received: from yx-out-1718.google.com ([74.125.44.156]:51465) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KyRs7-0006OU-CE for qemu-devel@nongnu.org; Fri, 07 Nov 2008 08:59:35 -0500 Received: by yx-out-1718.google.com with SMTP id 3so467971yxi.82 for ; Fri, 07 Nov 2008 05:59:34 -0800 (PST) Message-ID: <491449C4.4070500@codemonkey.ws> Date: Fri, 07 Nov 2008 07:59:32 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0/4] qcow2: Improve cluster refcount update References: <1225990556.6576.10.camel@frecb07144> <49133D17.3050100@codemonkey.ws> <1226047453.4046.4.camel@frecb07144> In-Reply-To: <1226047453.4046.4.camel@frecb07144> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Laurent Vivier wrote: > BTW, patch #1 is a clean-up (no change, only code move) and patch #2 > doesn't align buffer, but try to minimise syscall (it improves > performance with O_DSYNC too). > > Ignore patch #3 and #4 if you dislike them. > But how useful is #1 and #2 if the buffers aren't aligned and we're hitting the slow path? Regards, Anthony Liguori > Regards, > Laurent >