qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [5636] Run timers from host alarm timer callback
Date: Fri, 07 Nov 2008 08:06:30 -0600	[thread overview]
Message-ID: <49144B66.8080601@codemonkey.ws> (raw)
In-Reply-To: <3e1533500811070352x2c3430b9k1eab7af8795f163d@mail.gmail.com>

Luis Pureza wrote:
> Hi,
>
> This commit caused a noticeable slowdown while using the instruction
> counting mechanism. I'm testing with the sparc-test image and with
> --icount auto.
>   

Yeah, I take it that all timers don't result in signals when using 
icount and that we rely on select() timeout instead.  Let me look a 
little more closely at the code and I'll come up with a fix.

Regards,

Anthony Liguori

> Any ideas?
>
> Thanks,
>
> Luís Pureza
>
> On Wed, Nov 5, 2008 at 9:08 PM, Anthony Liguori <anthony@codemonkey.ws> wrote:
>   
>> Anthony Liguori wrote:
>>     
>>> Revision: 5636
>>>          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5636
>>> Author:   aliguori
>>> Date:     2008-11-05 21:04:35 +0000 (Wed, 05 Nov 2008)
>>>
>>> Log Message:
>>> -----------
>>> Run timers from host alarm timer callback
>>>
>>> This further cleans up the main loop getting it a lot closer to what a
>>> main
>>> loop should be.
>>>
>>> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>>>
>>>       
>> I've tested this with a variety of clocks and guests but this could uncover
>> more bugs like the previous 5s select sleep.  If things start slowing down,
>> please try this changeset first and let me know.
>>
>> Regards,
>>
>> Anthony Liguori
>>
>>
>>
>>
>>     
>
>
>   

  reply	other threads:[~2008-11-07 14:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-05 21:04 [Qemu-devel] [5636] Run timers from host alarm timer callback Anthony Liguori
2008-11-05 21:08 ` Anthony Liguori
2008-11-07 11:52   ` Luis Pureza
2008-11-07 14:06     ` Anthony Liguori [this message]
2008-11-07 16:23       ` Paul Brook
2008-11-11 21:00       ` Anthony Liguori
2008-11-11 23:42         ` Luis Pureza

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49144B66.8080601@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).