From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KyRyu-00035f-TU
	for qemu-devel@nongnu.org; Fri, 07 Nov 2008 09:06:36 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KyRyt-00034k-4y
	for qemu-devel@nongnu.org; Fri, 07 Nov 2008 09:06:36 -0500
Received: from [199.232.76.173] (port=47787 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KyRyt-00034c-0q
	for qemu-devel@nongnu.org; Fri, 07 Nov 2008 09:06:35 -0500
Received: from qw-out-1920.google.com ([74.125.92.150]:48716)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KyRys-0008GL-Jc
	for qemu-devel@nongnu.org; Fri, 07 Nov 2008 09:06:34 -0500
Received: by qw-out-1920.google.com with SMTP id 5so862441qwc.4
	for <qemu-devel@nongnu.org>; Fri, 07 Nov 2008 06:06:33 -0800 (PST)
Message-ID: <49144B66.8080601@codemonkey.ws>
Date: Fri, 07 Nov 2008 08:06:30 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [5636] Run timers from host alarm timer callback
References: <E1KxpYJ-0001Cj-Mu@cvs.savannah.gnu.org>	<49120B5F.5000805@codemonkey.ws>
	<3e1533500811070352x2c3430b9k1eab7af8795f163d@mail.gmail.com>
In-Reply-To: <3e1533500811070352x2c3430b9k1eab7af8795f163d@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Luis Pureza wrote:
> Hi,
>
> This commit caused a noticeable slowdown while using the instruction
> counting mechanism. I'm testing with the sparc-test image and with
> --icount auto.
>   

Yeah, I take it that all timers don't result in signals when using 
icount and that we rely on select() timeout instead.  Let me look a 
little more closely at the code and I'll come up with a fix.

Regards,

Anthony Liguori

> Any ideas?
>
> Thanks,
>
> Luís Pureza
>
> On Wed, Nov 5, 2008 at 9:08 PM, Anthony Liguori <anthony@codemonkey.ws> wrote:
>   
>> Anthony Liguori wrote:
>>     
>>> Revision: 5636
>>>          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5636
>>> Author:   aliguori
>>> Date:     2008-11-05 21:04:35 +0000 (Wed, 05 Nov 2008)
>>>
>>> Log Message:
>>> -----------
>>> Run timers from host alarm timer callback
>>>
>>> This further cleans up the main loop getting it a lot closer to what a
>>> main
>>> loop should be.
>>>
>>> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>>>
>>>       
>> I've tested this with a variety of clocks and guests but this could uncover
>> more bugs like the previous 5s select sleep.  If things start slowing down,
>> please try this changeset first and let me know.
>>
>> Regards,
>>
>> Anthony Liguori
>>
>>
>>
>>
>>     
>
>
>