From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KyTip-00046Y-AY
	for qemu-devel@nongnu.org; Fri, 07 Nov 2008 10:58:07 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KyTin-00043T-DG
	for qemu-devel@nongnu.org; Fri, 07 Nov 2008 10:58:06 -0500
Received: from [199.232.76.173] (port=45765 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KyTin-00043D-5t
	for qemu-devel@nongnu.org; Fri, 07 Nov 2008 10:58:05 -0500
Received: from mx2.redhat.com ([66.187.237.31]:60416)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1KyTim-0005av-L1
	for qemu-devel@nongnu.org; Fri, 07 Nov 2008 10:58:04 -0500
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id mA7Fw1gx020925
	for <qemu-devel@nongnu.org>; Fri, 7 Nov 2008 10:58:03 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])
	by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id mA7Fw18S024334
	for <qemu-devel@nongnu.org>; Fri, 7 Nov 2008 10:58:01 -0500
Received: from zweiblum.travel.kraxel.org (vpn-4-83.str.redhat.com
	[10.32.4.83])
	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id mA7FvxmW027954
	for <qemu-devel@nongnu.org>; Fri, 7 Nov 2008 10:58:00 -0500
Message-ID: <49146587.4040100@redhat.com>
Date: Fri, 07 Nov 2008 16:57:59 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] kvm: sync registers?
References: <491416EA.30706@redhat.com> <49144ABA.1030606@codemonkey.ws>
In-Reply-To: <49144ABA.1030606@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Anthony Liguori wrote:
> Gerd Hoffmann wrote:
>>   Hi,
>>
>> How does kvm sync registers between kernel and qemu env?
>> I see there are kvm_arch_{get,put}_registers() functions in
>> target-i386/kvm.c, but grep doesn't find a single call of them?
> 
> Right now, it doesn't.

Ok.  No wonder xenner doesn't boot xen pv guest kernels then.  kvm
doesn't see the protected-mode start-of-day setup done ...

> We should probably sync registers in the same 
> places that kvm-userspace does (gdbstubs, vmport, etc.).

Yep.

> I tried to always sync registers on every exit but this causes boot to
> fail. The same is true of kvm-userspace though and I've been meaning to
> dig into why this is.

Or that.  And maybe have a flag indicating qemu changed register state,
i.e. next vmenter must sync too.

cheers,
  Gerd