From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Kzdkn-0004cG-Oq
	for qemu-devel@nongnu.org; Mon, 10 Nov 2008 15:52:57 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Kzdkm-0004bw-AQ
	for qemu-devel@nongnu.org; Mon, 10 Nov 2008 15:52:57 -0500
Received: from [199.232.76.173] (port=41526 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Kzdkm-0004bt-6f
	for qemu-devel@nongnu.org; Mon, 10 Nov 2008 15:52:56 -0500
Received: from an-out-0708.google.com ([209.85.132.241]:51239)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Kzdkl-0006v0-U0
	for qemu-devel@nongnu.org; Mon, 10 Nov 2008 15:52:56 -0500
Received: by an-out-0708.google.com with SMTP id c38so384741ana.37
	for <qemu-devel@nongnu.org>; Mon, 10 Nov 2008 12:52:55 -0800 (PST)
Message-ID: <49189F23.7080406@codemonkey.ws>
Date: Mon, 10 Nov 2008 14:52:51 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 0/4] qcow2: Improve cluster refcount update
References: <1225990556.6576.10.camel@frecb07144>	<49133D17.3050100@codemonkey.ws>	<1226047453.4046.4.camel@frecb07144>	<491449C4.4070500@codemonkey.ws>	<1226070063.4046.56.camel@frecb07144>	<491460D2.4060203@codemonkey.ws>
	<36DB82BE-B858-4296-B60A-FDA69FF1760F@web.de>
In-Reply-To: <36DB82BE-B858-4296-B60A-FDA69FF1760F@web.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Andreas Färber wrote:
>
> Am 07.11.2008 um 16:37 schrieb Anthony Liguori:
>
>> Laurent Vivier wrote:
>>> Le vendredi 07 novembre 2008 ā 07:59 -0600, Anthony Liguori a écrit :
>>> In all cases #1 is totally useless as it is only cosmetic.
>>>
>>> #2 improves performance without aligned buffers and with "cache" set to
>>> default value.
>>>
>>
>> I'm currently rewriting the block-raw-posix.c O_DIRECT support.  I'll 
>> commit your patches once I finish that.
>>
>> I'm switching everything to use the aio functions,
>
> I'm not familiar with this area of code, so just as a reminder for 
> consideration, recently Blue Swirl added an option to disable AIO. 
> Some BSDs as well as Haiku may not have (full) POSIX AIO support. 
> Dumping non-AIO code for better performance on Linux would seem to 
> counterpoint the broadening platform support?

We can emulate AIO either via a bottom half and synchronous IO (not 
great) or using pthreads (better).  I have patches for both.  Mixing 
synchronous IO and asynchronous has all sorts of really ugly consequences.

Regards,

Anthony Liguori

> Andreas
>
>
>