From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KzwO2-000748-A0 for qemu-devel@nongnu.org; Tue, 11 Nov 2008 11:46:42 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KzwO0-00072z-DF for qemu-devel@nongnu.org; Tue, 11 Nov 2008 11:46:41 -0500 Received: from [199.232.76.173] (port=51614 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KzwNz-00072p-QS for qemu-devel@nongnu.org; Tue, 11 Nov 2008 11:46:40 -0500 Received: from yw-out-1718.google.com ([74.125.46.154]:9791) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KzwO0-0006mH-0j for qemu-devel@nongnu.org; Tue, 11 Nov 2008 11:46:40 -0500 Received: by yw-out-1718.google.com with SMTP id 6so1092313ywa.82 for ; Tue, 11 Nov 2008 08:46:38 -0800 (PST) Message-ID: <4919B6EA.70007@codemonkey.ws> Date: Tue, 11 Nov 2008 10:46:34 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH] Re: Live migration - exec: support to be reintroduced? (r2) References: <49113157.3090101@codemonkey.ws> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Charles Duffy wrote: > The attached version refactors to reduce the amount of duplicate code > between migrate-tcp and migrate-exec. Applied. Thanks. Although I'd rather see a qemu_fopen_file() or something similar that took a FILE * instead of qemu_popen[_cmd](). A follow up patch would be appreciated. Regards, Anthony Liguori