qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [patch] kvm: also fill 0x40000000 (vmm) cpuid leafes.
Date: Tue, 11 Nov 2008 22:30:36 +0100	[thread overview]
Message-ID: <4919F97C.6000200@redhat.com> (raw)
In-Reply-To: <4919F326.4070902@codemonkey.ws>

Anthony Liguori wrote:
> Gerd Hoffmann wrote:
>>   Hi,
>>
>> $subject says all, patch attached.
>>   
> 
> It really doesn't :-)
> 
> 0x4000xxxx are the virtualization leaves, that we don't set so there is
> no functional change from this patch.

Not yet.  For now it hasn't any effect.  I can keep it in my patch queue
until I submit the patches depending on that one.  But I expect more
users that xenner, so I thought it might be useful for others too and
submitted it right away ...

> The KVM PV ABI doesn't use eax as
> the max CPUID leaf of 0x40000000 so that's at least one example of them
> not behaving like this.

Oops.  I think we should fix it then to follow the usual eax convention.
 Xenner (standalone version, not qemu-integrated) actually does that and
sets eax to KVM_CPUID_FEATURES.

> So can you be a lot more specific about how you intend on using these
> leaves?

qemu-integrated xenner can handle full virtualized guests with xen pv
drivers installed.  Must provide xen virt cpuid leaves then.

cheers,
  Gerd

      reply	other threads:[~2008-11-11 21:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-07  9:44 [Qemu-devel] [patch] kvm: also fill 0x40000000 (vmm) cpuid leafes Gerd Hoffmann
2008-11-11 21:03 ` Anthony Liguori
2008-11-11 21:30   ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4919F97C.6000200@redhat.com \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).