From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L00ou-0002qk-Fr for qemu-devel@nongnu.org; Tue, 11 Nov 2008 16:30:44 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L00os-0002q7-UI for qemu-devel@nongnu.org; Tue, 11 Nov 2008 16:30:44 -0500 Received: from [199.232.76.173] (port=36694 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L00os-0002q2-Oh for qemu-devel@nongnu.org; Tue, 11 Nov 2008 16:30:42 -0500 Received: from mx2.redhat.com ([66.187.237.31]:45125) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L00or-0001JV-4Y for qemu-devel@nongnu.org; Tue, 11 Nov 2008 16:30:41 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id mABLUcN6018895 for ; Tue, 11 Nov 2008 16:30:38 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id mABLUcuf024260 for ; Tue, 11 Nov 2008 16:30:38 -0500 Received: from zweiblum.travel.kraxel.org (vpn-4-149.str.redhat.com [10.32.4.149]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id mABLUaJQ009797 for ; Tue, 11 Nov 2008 16:30:37 -0500 Message-ID: <4919F97C.6000200@redhat.com> Date: Tue, 11 Nov 2008 22:30:36 +0100 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [patch] kvm: also fill 0x40000000 (vmm) cpuid leafes. References: <49140DEE.7070000@redhat.com> <4919F326.4070902@codemonkey.ws> In-Reply-To: <4919F326.4070902@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Anthony Liguori wrote: > Gerd Hoffmann wrote: >> Hi, >> >> $subject says all, patch attached. >> > > It really doesn't :-) > > 0x4000xxxx are the virtualization leaves, that we don't set so there is > no functional change from this patch. Not yet. For now it hasn't any effect. I can keep it in my patch queue until I submit the patches depending on that one. But I expect more users that xenner, so I thought it might be useful for others too and submitted it right away ... > The KVM PV ABI doesn't use eax as > the max CPUID leaf of 0x40000000 so that's at least one example of them > not behaving like this. Oops. I think we should fix it then to follow the usual eax convention. Xenner (standalone version, not qemu-integrated) actually does that and sets eax to KVM_CPUID_FEATURES. > So can you be a lot more specific about how you intend on using these > leaves? qemu-integrated xenner can handle full virtualized guests with xen pv drivers installed. Must provide xen virt cpuid leaves then. cheers, Gerd