From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L01Py-0000PC-Np
	for qemu-devel@nongnu.org; Tue, 11 Nov 2008 17:09:02 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L01Px-0000On-MX
	for qemu-devel@nongnu.org; Tue, 11 Nov 2008 17:09:02 -0500
Received: from [199.232.76.173] (port=36409 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L01Px-0000Od-FF
	for qemu-devel@nongnu.org; Tue, 11 Nov 2008 17:09:01 -0500
Received: from mail-gx0-f16.google.com ([209.85.217.16]:49083)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1L01Px-0005RT-4Y
	for qemu-devel@nongnu.org; Tue, 11 Nov 2008 17:09:01 -0500
Received: by gxk9 with SMTP id 9so493854gxk.8
	for <qemu-devel@nongnu.org>; Tue, 11 Nov 2008 14:09:00 -0800 (PST)
Message-ID: <491A0252.2050401@codemonkey.ws>
Date: Tue, 11 Nov 2008 16:08:18 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Define OS-dependent qemu_getpagesize()
References: <ca05fc2e0d764bbfd45a.1226352804@localhost.localdomain>
In-Reply-To: <ca05fc2e0d764bbfd45a.1226352804@localhost.localdomain>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: kvm-ppc@vger.kernel.org

Hollis Blanchard wrote:
> Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>
>   

This breaks the -linux-user build.

> diff --git a/qemu/exec.c b/qemu/exec.c
> --- a/qemu/exec.c
> +++ b/qemu/exec.c
> @@ -239,16 +239,7 @@ static void page_init(void)
>  {
>      /* NOTE: we can always suppose that qemu_host_page_size >=
>         TARGET_PAGE_SIZE */
> -#ifdef _WIN32
> -    {
> -        SYSTEM_INFO system_info;
> -
> -        GetSystemInfo(&system_info);
> -        qemu_real_host_page_size = system_info.dwPageSize;
> -    }
> -#else
> -    qemu_real_host_page_size = getpagesize();
> -#endif
> +    qemu_real_host_page_size = qemu_getpagesize();
>      if (qemu_host_page_size == 0)
>          qemu_host_page_size = qemu_real_host_page_size;
>      if (qemu_host_page_size < TARGET_PAGE_SIZE)
>   

This is only used by -linux-user, which does not use osdep.c.

I've reverted this changeset and changed qemu_vmalloc() to just use 
getpagesize().

Regards,

Anthony Liguori