From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [5685] Disable debug code for production.
Date: Wed, 12 Nov 2008 16:22:35 +0100 [thread overview]
Message-ID: <491AF4BB.9020904@aurel32.net> (raw)
In-Reply-To: <200811121250.56809.paul@codesourcery.com>
Paul Brook a écrit :
>> /* allow to see translation results - the slowdown should be negligible,
>> so we leave it */
>> -#define DEBUG_DISAS
>> +//#define DEBUG_DISAS
>
> Why? As the comment says this has almost no runtime overhead, so there's no
> real downside to leaving it enabled. After your change the code is
> inconsistent with the comment.
> If we really want to disble this for production builds then IMHO it can be
> done by whoever spins the release.
>
This has been committed by mistake, and reverted later.
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
prev parent reply other threads:[~2008-11-12 15:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-11 13:30 [Qemu-devel] [5685] Disable debug code for production Aurelien Jarno
2008-11-12 12:50 ` Paul Brook
2008-11-12 15:22 ` Aurelien Jarno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491AF4BB.9020904@aurel32.net \
--to=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).