From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L0HYO-0006en-WC
	for qemu-devel@nongnu.org; Wed, 12 Nov 2008 10:22:49 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L0HYM-0006eY-Gk
	for qemu-devel@nongnu.org; Wed, 12 Nov 2008 10:22:47 -0500
Received: from [199.232.76.173] (port=54803 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L0HYM-0006eR-2u
	for qemu-devel@nongnu.org; Wed, 12 Nov 2008 10:22:46 -0500
Received: from hall.aurel32.net ([88.191.82.174]:42734)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <aurelien@aurel32.net>)
	id 1L0HYL-0007Yv-Tf
	for qemu-devel@nongnu.org; Wed, 12 Nov 2008 10:22:46 -0500
Received: from anguille.univ-lyon1.fr ([134.214.4.207])
	by hall.aurel32.net with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.63) (envelope-from <aurelien@aurel32.net>)
	id 1L0HYG-0008HN-F1
	for qemu-devel@nongnu.org; Wed, 12 Nov 2008 16:22:40 +0100
Message-ID: <491AF4BB.9020904@aurel32.net>
Date: Wed, 12 Nov 2008 16:22:35 +0100
From: Aurelien Jarno <aurelien@aurel32.net>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [5685] Disable debug code for production.
References: <E1KztK7-0008Ke-2B@cvs.savannah.gnu.org>
	<200811121250.56809.paul@codesourcery.com>
In-Reply-To: <200811121250.56809.paul@codesourcery.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Paul Brook a écrit :
>>  /* allow to see translation results - the slowdown should be negligible,
>> so we leave it */
>> -#define DEBUG_DISAS 
>> +//#define DEBUG_DISAS
> 
> Why? As the comment says this has almost no runtime overhead, so there's no 
> real downside to leaving it enabled. After your change the code is 
> inconsistent with the comment.
> If we really want to disble this for production builds then IMHO it can be 
> done by whoever spins the release.
> 

This has been committed by mistake, and reverted later.

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net