From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L0fie-0001cu-HR for qemu-devel@nongnu.org; Thu, 13 Nov 2008 12:11:00 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L0fid-0001c0-Jf for qemu-devel@nongnu.org; Thu, 13 Nov 2008 12:10:59 -0500 Received: from [199.232.76.173] (port=57265 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L0fic-0001bY-S5 for qemu-devel@nongnu.org; Thu, 13 Nov 2008 12:10:58 -0500 Received: from gecko.sbs.de ([194.138.37.40]:21760) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L0fib-0003sm-UM for qemu-devel@nongnu.org; Thu, 13 Nov 2008 12:10:59 -0500 Message-ID: <491C5F77.1040006@siemens.com> Date: Thu, 13 Nov 2008 18:10:15 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <> <1226594526-1855-1-git-send-email-markmc@redhat.com> <1226594526-1855-2-git-send-email-markmc@redhat.com> In-Reply-To: <1226594526-1855-2-git-send-email-markmc@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] Re: [PATCH 2/3] dyngen: fix some warnings about unused functions Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Mark McLoughlin Mark McLoughlin wrote: > Warnings were: >=20 > dyngen.c:292: error: =E2=80=98pstrcpy=E2=80=99 defined but not used >=20 > Only used with CONFIG_FORMAT_COFF >=20 > dyngen.c:319: error: =E2=80=98swab32ss=E2=80=99 defined but not used >=20 > With ELF_USES_RELOCA, either swab32ss() or swab64ss() will > be used depending on ELF_CLASS. Easier to just mark them > both as unused. >=20 > dyngen.c:334: error: =E2=80=98get16=E2=80=99 defined but not used > dyngen.c:343: error: =E2=80=98get32=E2=80=99 defined but not used > dyngen.c:352: error: =E2=80=98put16=E2=80=99 defined but not used > dyngen.c:359: error: =E2=80=98put32=E2=80=99 defined but not used >=20 > Maybe be used for some host arches; easiest to mark them as > unused. >=20 > dyngen.c:425: error: =E2=80=98elf_swap_phdr=E2=80=99 defined but not = used >=20 > This one is completely unused; just delete. As far as I understood, the whole file will disappear soon (once ongoing PPC conversion to TCG is completed). I gave up hunting after the dyngen warning mess for this reason. However, welcome to the club of warning fighters! Hope you'll have more luck than others (including me). :) Jan --=20 Siemens AG, Corporate Technology, CT SE 2 ES-OS Corporate Competence Center Embedded Linux