From: Anthony Liguori <anthony@codemonkey.ws>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Mark McLoughlin <markmc@redhat.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 1/3] x86: fix warning without CONFIG_KVM
Date: Thu, 13 Nov 2008 13:31:19 -0600 [thread overview]
Message-ID: <491C8087.7060302@codemonkey.ws> (raw)
In-Reply-To: <491C5F51.20205@siemens.com>
Jan Kiszka wrote:
> Isn't it cleaner to provide an empty static inline in the !CONFIG_KVM
> case? Not all compilers might be smart enough to optimize this function
> away.
>
kvm_enabled() is (0) when !CONFIG_KVM so that's why this is a warning
and not an error. The function call disappears during linking from dead
code elimination. There is no routine overhead when !CONFIG_KVM.
Regards,
Anthony Liguori
> Jan
>
>
next prev parent reply other threads:[~2008-11-13 19:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-13 16:42 [Qemu-devel] [PATCH 1/3] x86: fix warning without CONFIG_KVM Mark McLoughlin
2008-11-13 16:42 ` [Qemu-devel] [PATCH 2/3] dyngen: fix some warnings about unused functions Mark McLoughlin
2008-11-13 16:42 ` [Qemu-devel] [PATCH 3/3] cris: fix a segfault if pflash drive not found Mark McLoughlin
2008-11-13 19:37 ` [Qemu-devel] " Anthony Liguori
2008-11-13 20:57 ` Edgar E. Iglesias
2008-11-13 17:10 ` [Qemu-devel] Re: [PATCH 2/3] dyngen: fix some warnings about unused functions Jan Kiszka
2008-11-13 19:39 ` Anthony Liguori
2008-11-14 15:25 ` Mark McLoughlin
2008-11-13 17:09 ` [Qemu-devel] Re: [PATCH 1/3] x86: fix warning without CONFIG_KVM Jan Kiszka
2008-11-13 19:31 ` Anthony Liguori [this message]
2008-11-14 3:22 ` Jamie Lokier
2008-11-13 19:38 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491C8087.7060302@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=jan.kiszka@siemens.com \
--cc=markmc@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).