From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L0i2J-00070C-9Y
	for qemu-devel@nongnu.org; Thu, 13 Nov 2008 14:39:27 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L0i2H-0006yc-Om
	for qemu-devel@nongnu.org; Thu, 13 Nov 2008 14:39:26 -0500
Received: from [199.232.76.173] (port=49235 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L0i2H-0006yF-AI
	for qemu-devel@nongnu.org; Thu, 13 Nov 2008 14:39:25 -0500
Received: from yx-out-1718.google.com ([74.125.44.156]:1211)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1L0i2H-0007EF-4R
	for qemu-devel@nongnu.org; Thu, 13 Nov 2008 14:39:25 -0500
Received: by yx-out-1718.google.com with SMTP id 3so448336yxi.82
	for <qemu-devel@nongnu.org>; Thu, 13 Nov 2008 11:39:23 -0800 (PST)
Message-ID: <491C8267.9010303@codemonkey.ws>
Date: Thu, 13 Nov 2008 13:39:19 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <> <1226594526-1855-1-git-send-email-markmc@redhat.com>
	<1226594526-1855-2-git-send-email-markmc@redhat.com>
In-Reply-To: <1226594526-1855-2-git-send-email-markmc@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: [Qemu-devel] Re: [PATCH 2/3] dyngen: fix some warnings about unused
	functions
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mark McLoughlin <markmc@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

Mark McLoughlin wrote:
> Warnings were:
>
>   dyngen.c:292: error: ‘pstrcpy’ defined but not used
>
> Only used with CONFIG_FORMAT_COFF
>
>   dyngen.c:319: error: ‘swab32ss’ defined but not used
>
> With ELF_USES_RELOCA, either swab32ss() or swab64ss() will
> be used depending on ELF_CLASS. Easier to just mark them
> both as unused.
>
>   dyngen.c:334: error: ‘get16’ defined but not used
>   dyngen.c:343: error: ‘get32’ defined but not used
>   dyngen.c:352: error: ‘put16’ defined but not used
>   dyngen.c:359: error: ‘put32’ defined but not used
>
> Maybe be used for some host arches; easiest to mark them as
> unused.
>
>   dyngen.c:425: error: ‘elf_swap_phdr’ defined but not used
>
> This one is completely unused; just delete.
>   

Since dyngen is going away soon, I'm not eager to make changes to it 
that could possibly break on some weird architecture.  Do you think it 
would be terrible to just ignore this for now?

If someone else is more confident that this is okay, I think it's fine 
to commit.

Regards,

Anthony Liguori