From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L0i7d-0003PO-S0
	for qemu-devel@nongnu.org; Thu, 13 Nov 2008 14:44:58 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L0i7c-0003No-2U
	for qemu-devel@nongnu.org; Thu, 13 Nov 2008 14:44:57 -0500
Received: from [199.232.76.173] (port=40716 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L0i7b-0003Nh-To
	for qemu-devel@nongnu.org; Thu, 13 Nov 2008 14:44:55 -0500
Received: from yw-out-1718.google.com ([74.125.46.156]:4013)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1L0i7b-0007qc-Lm
	for qemu-devel@nongnu.org; Thu, 13 Nov 2008 14:44:55 -0500
Received: by yw-out-1718.google.com with SMTP id 6so450553ywa.82
	for <qemu-devel@nongnu.org>; Thu, 13 Nov 2008 11:44:54 -0800 (PST)
Message-ID: <491C83B2.8010003@codemonkey.ws>
Date: Thu, 13 Nov 2008 13:44:50 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <> <1226594763-2304-1-git-send-email-markmc@redhat.com>
	<1226594763-2304-2-git-send-email-markmc@redhat.com>
In-Reply-To: <1226594763-2304-2-git-send-email-markmc@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 1/5] Re-factor nic model listing
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mark McLoughlin <markmc@redhat.com>
Cc: qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>

Mark McLoughlin wrote:
> Add a nic_models() method to QEMUMachine and move the nic model
> listing from hw/pc.c to vl.c.
>
> pci_nic_models() is hooked up to all machines which use
> pci_nic_init().
>
> The isapc machine is the only one which is slightly different
> since it only supports the ne2k_isa model.
>   

In principle, I think this patch series is a good idea.  I think the 
abstraction here is a little broken.

I don't think it's correct to associate nics directly with a machine 
type.  Rather, nics have bus requirements (like PCI, ISA, or USB) and a 
machine may or may not contain that bus.

Regards,

Anthony Liguori