From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L0ixs-0002gW-2r for qemu-devel@nongnu.org; Thu, 13 Nov 2008 15:38:56 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L0ixn-0002fg-Gh for qemu-devel@nongnu.org; Thu, 13 Nov 2008 15:38:54 -0500 Received: from [199.232.76.173] (port=43283 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L0ixn-0002fT-4s for qemu-devel@nongnu.org; Thu, 13 Nov 2008 15:38:51 -0500 Received: from qw-out-1920.google.com ([74.125.92.150]:39458) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L0ixm-0004fu-IK for qemu-devel@nongnu.org; Thu, 13 Nov 2008 15:38:50 -0500 Received: by qw-out-1920.google.com with SMTP id 5so838444qwc.4 for ; Thu, 13 Nov 2008 12:38:49 -0800 (PST) Message-ID: <491C9056.6090005@codemonkey.ws> Date: Thu, 13 Nov 2008 14:38:46 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 00/12] Enhance debugging support - 4th take References: <20081103103558.213902776@mchn012c.ww002.siemens.net> In-Reply-To: <20081103103558.213902776@mchn012c.ww002.siemens.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Jan Kiszka Hi Jan, Jan Kiszka wrote: > Yet another round for the gdbstub and debug regs patches. > First, thanks for your patience with this series. Unfortunately, there isn't a very clear target-i386 maintainer right now so this series hasn't gotten the feedback it should have gotten. I feel a little uneasy about committing it because I don't have complete confidence in the impact with TCG but after reviewing it and I don't have a setup prepared to reliably test it all, I feel pretty certain that it's not going to blow things up. I have some minor comments for some of the patches. Once you address them, I'll apply the series unless there is objection before you post the next round. In terms of my exec.c split, I'll wait to commit the code motion until after your series has been merged to keep rebasing easy for you. Regards, Anthony Liguori