From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L0jAc-0007aX-Ry for qemu-devel@nongnu.org; Thu, 13 Nov 2008 15:52:06 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L0jAb-0007Zg-Bs for qemu-devel@nongnu.org; Thu, 13 Nov 2008 15:52:06 -0500 Received: from [199.232.76.173] (port=36028 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L0jAb-0007Zd-8b for qemu-devel@nongnu.org; Thu, 13 Nov 2008 15:52:05 -0500 Received: from ug-out-1314.google.com ([66.249.92.173]:44213) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L0jAa-0005iD-Ru for qemu-devel@nongnu.org; Thu, 13 Nov 2008 15:52:05 -0500 Received: by ug-out-1314.google.com with SMTP id 29so1736244ugc.36 for ; Thu, 13 Nov 2008 12:52:03 -0800 (PST) Message-ID: <491C936E.8050808@codemonkey.ws> Date: Thu, 13 Nov 2008 14:51:58 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 03/12] Refactor and enhance break/watchpoint API References: <20081103103558.213902776@mchn012c.ww002.siemens.net> <20081103103559.071243441@mchn012c.ww002.siemens.net> In-Reply-To: <20081103103559.071243441@mchn012c.ww002.siemens.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Jan Kiszka Jan Kiszka wrote: > This patch prepares the QEMU cpu_watchpoint/breakpoint API to allow the > succeeding enhancements this series comes with. > > First of all, it overcomes MAX_BREAKPOINTS/MAX_WATCHPOINTS by switching > to dynamically allocated data structures that are kept in linked lists. > This also allows to return a stable reference to the related objects, > required for later introduced x86 debug register support. > > Breakpoints and watchpoints are stored with their full information set > and an additional flag field that makes them easily extensible for use > beyond pure guest debugging. > > Finally, this restructuring lays the foundation for KVM to hook into > the debugging infrastructure, providing its own services where hardware > virtualization demands it. Once QEMUAccel is considered for merge, > those entry point should be included into its abstraction layer so that > accellerators can hook in even more cleanly. > We've merged KVM support (although not QEMUAccel), so perhaps you can also add the KVM hooks in this series that you are thinking of? Regards, Anthony Liguori