From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L0l8g-0006TW-Kv for qemu-devel@nongnu.org; Thu, 13 Nov 2008 17:58:14 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L0l8e-0006TK-R9 for qemu-devel@nongnu.org; Thu, 13 Nov 2008 17:58:13 -0500 Received: from [199.232.76.173] (port=58913 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L0l8e-0006TG-Kp for qemu-devel@nongnu.org; Thu, 13 Nov 2008 17:58:12 -0500 Received: from fmmailgate01.web.de ([217.72.192.221]:57856) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L0l8e-0000oh-2m for qemu-devel@nongnu.org; Thu, 13 Nov 2008 17:58:12 -0500 Message-ID: <491CB100.4010602@web.de> Date: Thu, 13 Nov 2008 23:58:08 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <20081103103558.213902776@mchn012c.ww002.siemens.net> <20081103103559.071243441@mchn012c.ww002.siemens.net> <491C936E.8050808@codemonkey.ws> In-Reply-To: <491C936E.8050808@codemonkey.ws> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig2748084E1E39F585B9E4B92C" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH 03/12] Refactor and enhance break/watchpoint API Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Jan Kiszka This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig2748084E1E39F585B9E4B92C Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Anthony Liguori wrote: > Jan Kiszka wrote: >> This patch prepares the QEMU cpu_watchpoint/breakpoint API to allow th= e >> succeeding enhancements this series comes with. >> >> First of all, it overcomes MAX_BREAKPOINTS/MAX_WATCHPOINTS by switchin= g >> to dynamically allocated data structures that are kept in linked lists= =2E >> This also allows to return a stable reference to the related objects, >> required for later introduced x86 debug register support. >> >> Breakpoints and watchpoints are stored with their full information set= >> and an additional flag field that makes them easily extensible for use= >> beyond pure guest debugging. >> >> Finally, this restructuring lays the foundation for KVM to hook into >> the debugging infrastructure, providing its own services where hardwar= e >> virtualization demands it. Once QEMUAccel is considered for merge, >> those entry point should be included into its abstraction layer so tha= t >> accellerators can hook in even more cleanly. >> =20 >=20 > We've merged KVM support (although not QEMUAccel), so perhaps you can > also add the KVM hooks in this series that you are thinking of? I will check how much of my kvm patches for guest debugging can already be ported over. That topic is more complex - if you recall my according series - as kvm requires kernel changes to gain full guest debugging support. I'm not even sure if it makes sense to add support for the current kernel interface as it is too restricted (no watchpoints, only 4 breakpoints). However, will re-check if some patch re-ordering may help the migration. Jan --------------enig2748084E1E39F585B9E4B92C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkkcsQAACgkQniDOoMHTA+nM+QCffWzaYJPOtRtB3n85m3M05KXA /q8AoIIHmgKQGUfEWUBWC+MfFWEsu84W =sY5/ -----END PGP SIGNATURE----- --------------enig2748084E1E39F585B9E4B92C--