From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L0lfm-0002qN-GK for qemu-devel@nongnu.org; Thu, 13 Nov 2008 18:32:26 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L0lfk-0002oa-O0 for qemu-devel@nongnu.org; Thu, 13 Nov 2008 18:32:26 -0500 Received: from [199.232.76.173] (port=53949 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L0lfk-0002oR-Jt for qemu-devel@nongnu.org; Thu, 13 Nov 2008 18:32:24 -0500 Received: from yx-out-1718.google.com ([74.125.44.155]:51068) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L0lfk-0005z2-Jt for qemu-devel@nongnu.org; Thu, 13 Nov 2008 18:32:24 -0500 Received: by yx-out-1718.google.com with SMTP id 3so491600yxi.82 for ; Thu, 13 Nov 2008 15:32:22 -0800 (PST) Message-ID: <491CB902.80803@codemonkey.ws> Date: Thu, 13 Nov 2008 17:32:18 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 00/12] Enhance debugging support - 4th take References: <20081103103558.213902776@mchn012c.ww002.siemens.net> <491CA4FD.8000202@bellard.org> <491CB052.5040809@web.de> In-Reply-To: <491CB052.5040809@web.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: jan.kiszka@siemens.com Jan Kiszka wrote: > No problem (as long as "later" doesn't mean another 5 months ;) ), > > Please keep in mind that this patch allows to run a lot of > debug-register-using guest code that broke so far. So, unless you or > someone else with deep x86 knowledge find issues during that code > inspection, hunting them via concrete test cases may be helpful as well. > Yeah, I think this is reasonable. As long as the patch is well isolated and easy to identify with a git bisect, I think it's okay. Regards, Anthony Liguori > Thanks for having a look! > Jan > > >