From: Anthony Liguori <anthony@codemonkey.ws>
To: Jamie Lokier <jamie@shareable.org>
Cc: Carsten Otte <cotte@de.ibm.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Hollis Blanchard <hollisb@us.ibm.com>,
kvm-devel <kvm@vger.kernel.org>,
qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH][RFC] Split non-TCG bits out of exec.c
Date: Fri, 14 Nov 2008 08:07:32 -0600 [thread overview]
Message-ID: <491D8624.50800@codemonkey.ws> (raw)
In-Reply-To: <20081114040311.GN2055@shareable.org>
Jamie Lokier wrote:
> Also, an earlier thread pointed out that loops doing a lot of MMIO are
> _slower_ with KVM than without - this manifested as very slow VGA
> output for some guests. Having KVM pass control to TCG for short runs
> of guest instructions which do MMIO, or other instructions which need
> to be emulated, would accelerate KVM in this respect.
>
Note, the devil is in the details here.
An MMIO exit to userspace typically costs around 6k cycles. On the
other hand, a TB translation tends to average closer to 300k often times
reaching much higher. This with was with dyngen so TCG may be more or
less expensive.
An in-kernel MMIO exit on the other hand will cost around 3k cycles.
MMIO coalescing is pretty efficient because it effectively reduces the
cost of a exit by half.
To make up the cost of TCG translation for just one TB, you need to have
a tight loop of at least 50 iterations. We can handle rep instructions
with a single exit in KVM so this needs to be an actual MMIO loop, not a
rep loop.
If you also consider all the potential locking issues with SMP guests, I
think it's pretty likely that there are few cases where dropping to TCG
is going to be a net performance win.
Regards,
Anthony Liguori
> -- Jamie
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2008-11-14 14:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-12 22:10 [Qemu-devel] [PATCH][RFC] Split non-TCG bits out of exec.c Anthony Liguori
2008-11-12 22:48 ` Fabrice Bellard
2008-11-12 22:53 ` Anthony Liguori
2008-11-13 13:51 ` andrzej zaborowski
2008-11-13 16:18 ` Anthony Liguori
2008-11-14 3:12 ` andrzej zaborowski
2008-11-14 3:18 ` Anthony Liguori
2008-11-14 13:45 ` andrzej zaborowski
2008-11-14 4:03 ` Jamie Lokier
2008-11-14 9:58 ` Avi Kivity
2008-11-14 13:23 ` Jamie Lokier
2008-11-16 13:07 ` Avi Kivity
2008-11-17 3:57 ` Jamie Lokier
2008-11-14 13:58 ` Anthony Liguori
2008-11-14 14:07 ` Anthony Liguori [this message]
2008-11-14 23:13 ` Jamie Lokier
2008-11-14 23:20 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491D8624.50800@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=aliguori@us.ibm.com \
--cc=cotte@de.ibm.com \
--cc=hollisb@us.ibm.com \
--cc=jamie@shareable.org \
--cc=kvm@vger.kernel.org \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).