From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L1GYL-00047V-Th for qemu-devel@nongnu.org; Sat, 15 Nov 2008 03:30:49 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L1GYL-00047I-E2 for qemu-devel@nongnu.org; Sat, 15 Nov 2008 03:30:49 -0500 Received: from [199.232.76.173] (port=50305 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L1GYL-00047F-7m for qemu-devel@nongnu.org; Sat, 15 Nov 2008 03:30:49 -0500 Received: from mx20.gnu.org ([199.232.41.8]:16938) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L1GYK-0007k7-PC for qemu-devel@nongnu.org; Sat, 15 Nov 2008 03:30:49 -0500 Received: from fmmailgate02.web.de ([217.72.192.227]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L1GYI-00054D-KX for qemu-devel@nongnu.org; Sat, 15 Nov 2008 03:30:46 -0500 Received: from smtp08.web.de (fmsmtp08.dlan.cinetic.de [172.20.5.216]) by fmmailgate02.web.de (Postfix) with ESMTP id 34268F6B8CDD for ; Sat, 15 Nov 2008 09:30:44 +0100 (CET) Received: from [88.65.32.198] (helo=[192.168.1.198]) by smtp08.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.109 #226) id 1L1GYG-0001CA-00 for qemu-devel@nongnu.org; Sat, 15 Nov 2008 09:30:44 +0100 Message-ID: <491E8887.7010004@web.de> Date: Sat, 15 Nov 2008 09:29:59 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <20081103103558.213902776@mchn012c.ww002.siemens.net> <20081103103559.071243441@mchn012c.ww002.siemens.net> <491C936E.8050808@codemonkey.ws> <491CB100.4010602@web.de> In-Reply-To: <491CB100.4010602@web.de> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigA7C571D0F1761237944E0DED" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH 03/12] Refactor and enhance break/watchpoint API Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigA7C571D0F1761237944E0DED Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Jan Kiszka wrote: > Anthony Liguori wrote: >> Jan Kiszka wrote: >>> This patch prepares the QEMU cpu_watchpoint/breakpoint API to allow t= he >>> succeeding enhancements this series comes with. >>> >>> First of all, it overcomes MAX_BREAKPOINTS/MAX_WATCHPOINTS by switchi= ng >>> to dynamically allocated data structures that are kept in linked list= s. >>> This also allows to return a stable reference to the related objects,= >>> required for later introduced x86 debug register support. >>> >>> Breakpoints and watchpoints are stored with their full information se= t >>> and an additional flag field that makes them easily extensible for us= e >>> beyond pure guest debugging. >>> >>> Finally, this restructuring lays the foundation for KVM to hook into >>> the debugging infrastructure, providing its own services where hardwa= re >>> virtualization demands it. Once QEMUAccel is considered for merge, >>> those entry point should be included into its abstraction layer so th= at >>> accellerators can hook in even more cleanly. >>> =20 >> We've merged KVM support (although not QEMUAccel), so perhaps you can >> also add the KVM hooks in this series that you are thinking of? >=20 > I will check how much of my kvm patches for guest debugging can already= > be ported over. >=20 > That topic is more complex - if you recall my according series - as kvm= > requires kernel changes to gain full guest debugging support. I'm not > even sure if it makes sense to add support for the current kernel > interface as it is too restricted (no watchpoints, only 4 breakpoints).= > However, will re-check if some patch re-ordering may help the migration= =2E >=20 I had a closer look meanwhile. Given the fact that there are no kvm bits for supporting guest debugging in qemu yet and that it would take some additional effort for me to establish this for the old interface, I would like to skip this step and suggest a different roadmap instead: o integrate plain qemu bits for full guest debugging (this series) o wait for Avi to merge them into kvm-userspace o rebase my kvm guest debugging series over kvm-userspace (kernel bits are already up to date) and submit it for review/merge o port stabilized kvm guest debugging over to qemu, but demanding the new kernel ABI OK? Time is a scarce resource, so I would really like to omit stabilizing a feature based on an outdated interface to a still too young (for daily use, including guest debugging) kvm support of qemu. Jan --------------enigA7C571D0F1761237944E0DED Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkkeiIsACgkQniDOoMHTA+kHWgCfbFwcYvRT+ZMJp6WEy0E6fiWg 0JwAnRvlpT/OmCDwm7lyu5IfOz3HxBJq =AbMD -----END PGP SIGNATURE----- --------------enigA7C571D0F1761237944E0DED--