From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B14AC433DB for ; Thu, 4 Feb 2021 16:36:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA84664F41 for ; Thu, 4 Feb 2021 16:36:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA84664F41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7hc2-00037J-L6 for qemu-devel@archiver.kernel.org; Thu, 04 Feb 2021 11:36:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7gvM-00077R-SX for qemu-devel@nongnu.org; Thu, 04 Feb 2021 10:52:04 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:34970) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l7gvL-0007rS-9P for qemu-devel@nongnu.org; Thu, 04 Feb 2021 10:52:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612453922; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rNvGdHDPTel76AXb5y85g56odthbxJcSUXz8brdhti0=; b=cp6EhIoelX1jvkf3jhGWgzJawpjlYB0Ri4F3dc/KpDUCtVswAD4I0HhekwVPTcmqU6vAJe GEn69L4OCIxoB0xrhpaX61Jnt4AS0U/tXPxH9gGFcnuW9OLc7Tjp6bZSn0PwxueetCfth5 jiesOACd1X7We+hd21AllJUWa/U/gEc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-314-LoKBGcBVNoia5iLTew12Iw-1; Thu, 04 Feb 2021 10:51:58 -0500 X-MC-Unique: LoKBGcBVNoia5iLTew12Iw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DA835192FDA0; Thu, 4 Feb 2021 15:51:57 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-90.ams2.redhat.com [10.36.112.90]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7BDDA197FA; Thu, 4 Feb 2021 15:51:40 +0000 (UTC) Subject: Re: [PATCH 4/4] hw/usb/bus: Remove the "full-path" property To: Gerd Hoffmann References: <20210203171832.483176-1-thuth@redhat.com> <20210203171832.483176-5-thuth@redhat.com> <20210204083648.b4tbk5kftdk4j6ez@sirius.home.kraxel.org> From: Thomas Huth Message-ID: <491c2cc6-ea07-d281-4dfc-01a81d02da77@redhat.com> Date: Thu, 4 Feb 2021 16:51:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210204083648.b4tbk5kftdk4j6ez@sirius.home.kraxel.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.351, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.182, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , qemu-block@nongnu.org, David Hildenbrand , libvir-list@redhat.com, "Michael S. Tsirkin" , qemu-devel@nongnu.org, Paolo Bonzini , John Snow Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 04/02/2021 09.36, Gerd Hoffmann wrote: > Hi, > >> enum USBDeviceFlags { >> - USB_DEV_FLAG_FULL_PATH, >> + USB_DEV_FLAG_FULL_PATH, /* unused since QEMU v6.0 */ > > Why not just drop it? Any remaining users? I didn't want to change the values of the other members of the enum ... but if you prefer, I can also a "= 1" after the next member of the enum and remove the USB_DEV_FLAG_FULL_PATH instead. Thomas