From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L2AIn-0008Gi-Lg
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 15:02:29 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L2AIl-0008Fv-Vc
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 15:02:29 -0500
Received: from [199.232.76.173] (port=41111 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L2AIl-0008Fo-Pc
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 15:02:27 -0500
Received: from an-out-0708.google.com ([209.85.132.242]:15508)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1L2AIk-0002KS-Iv
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 15:02:26 -0500
Received: by an-out-0708.google.com with SMTP id c38so998601ana.37
	for <qemu-devel@nongnu.org>; Mon, 17 Nov 2008 12:02:25 -0800 (PST)
Message-ID: <4921CDCD.1060100@codemonkey.ws>
Date: Mon, 17 Nov 2008 14:02:21 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [RESEND][PATCH] Add 40-bit DMA support to LSI
	scsi emulation
References: <20081117173417.GT31893@us.ibm.com>
	<f43fc5580811171125o2ed645ehcf28605d3c7e7546@mail.gmail.com>
In-Reply-To: <f43fc5580811171125o2ed645ehcf28605d3c7e7546@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Ryan Harper <ryanh@us.ibm.com>, Paul Brook <paul@codesourcery.com>

Blue Swirl wrote:
> On 11/17/08, Ryan Harper <ryanh@us.ibm.com> wrote:
>   
>>  Looking for some feedback on this patch, MAINTAINERS points to Paul for
>>  scsi stuff, and I saw Blue Swirl commit a scsi patch recently.
>>
>>  This patch fixes Linux machines configured with > 4G of ram and using a
>>  SCSI device.  I'm working on 64-bit DMA support as well which should
>>  hopefully fix 64-bit Windows using SCSI devices as well.
>>     
>
>     addr = s->dnad;
> +    if (lsi_dma_40bit(s))
> +        addr |= ((uint64_t)s->dnad64 << 32UL);
> +    else if (s->sbms)
> +        addr |= ((uint64_t)s->sbms << 32UL);
>
> Maybe the address could be calculated at script parsing phase for
> small performance gain.
>
> I would use ULL instead of UL, because on 32 bit host long is still 32 bits.
>   

But both ULL and UL are wrong for a shift operation.  It always takes an 
integer.

Regards,

Anthony Liguori