From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L2N3O-0005Me-Ne for qemu-devel@nongnu.org; Tue, 18 Nov 2008 04:39:26 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L2N3N-0005MO-2d for qemu-devel@nongnu.org; Tue, 18 Nov 2008 04:39:25 -0500 Received: from [199.232.76.173] (port=41740 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L2N3M-0005ML-Ta for qemu-devel@nongnu.org; Tue, 18 Nov 2008 04:39:24 -0500 Received: from hall.aurel32.net ([88.191.82.174]:37165) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L2N3M-0005sg-JV for qemu-devel@nongnu.org; Tue, 18 Nov 2008 04:39:24 -0500 Received: from anguille.univ-lyon1.fr ([134.214.4.207]) by hall.aurel32.net with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1L2N3H-0004yO-NS for qemu-devel@nongnu.org; Tue, 18 Nov 2008 10:39:19 +0100 Message-ID: <49228D42.8010006@aurel32.net> Date: Tue, 18 Nov 2008 10:39:14 +0100 From: Aurelien Jarno MIME-Version: 1.0 Subject: Re: [Qemu-devel] TCG debugging improvements References: <200811171445.40710.paul@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Blue Swirl a écrit : > On 11/17/08, Paul Brook wrote: >> I'd just applied changes that enforce type size checking for TCG variables >> when DEBUG_TCGV is defined. This should help avoid subtle bugs due to >> 64/32-bit mismatches. >> >> I fixed a few bugs in the process, but it's mostly mechanical changes. TCGv >> is target_ulong sized, so the majority of code remains unchanged. Explicit >> sizes are typically only required when working with different sized ops, or >> floating point. >> >> One of the main side-effects of this is that helper functions now need to be >> declared properly. Previously we sort-of did this, but not consistently >> enough to enforce types. With the exception of the SSE/MMX ops (which are >> table driven and use messy typecasts) we should be able to detect >> inconsistencies between the code generator and the helper function >> implementations. >> >> There should be no functional changes. I've tested what I can, but please >> test your favourite host/target. > > PPC is broken. This used to print something, now it doesn't: > ./qemu-system-ppc -L ./pc-bios/ -hda /dev/null > That should be fixed in the SVN. -- .''`. Aurelien Jarno | GPG: 1024D/F1BCDB73 : :' : Debian developer | Electrical Engineer `. `' aurel32@debian.org | aurelien@aurel32.net `- people.debian.org/~aurel32 | www.aurel32.net