From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L2W5a-00011h-TH
	for qemu-devel@nongnu.org; Tue, 18 Nov 2008 14:18:18 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L2W5Y-00010s-ET
	for qemu-devel@nongnu.org; Tue, 18 Nov 2008 14:18:17 -0500
Received: from [199.232.76.173] (port=46571 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L2W5Y-00010p-7f
	for qemu-devel@nongnu.org; Tue, 18 Nov 2008 14:18:16 -0500
Received: from gv-out-0910.google.com ([216.239.58.189]:64129)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1L2W5Y-0000LR-4B
	for qemu-devel@nongnu.org; Tue, 18 Nov 2008 14:18:16 -0500
Received: by gv-out-0910.google.com with SMTP id n8so588015gve.36
	for <qemu-devel@nongnu.org>; Tue, 18 Nov 2008 11:18:14 -0800 (PST)
Message-ID: <492314F1.20900@codemonkey.ws>
Date: Tue, 18 Nov 2008 13:18:09 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Fix media detection on emulated CDROM
References: <1227032396.17638.60.camel@ggrebus.katana-technology.com>
In-Reply-To: <1227032396.17638.60.camel@ggrebus.katana-technology.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Gary Grebus wrote:
> This patch tweaks the ATAPI CDROM emulation to fix an annoyance seen
> when running a variety of Linux guests: the desktop GUI shows a CDROM
> device as present, but is unable to automount the media and display its
> contents.
>
> The patch adds the PLAY_AUDIO capability bit to the data returned by
> MODE_SENSE commands.  That convinces the guest kernel to determine what
> kind of media is present.
>
> Arguably Linux could be smarter about this, but it's my guess there are
> few (if any) hardware CDROM drives that don't set the bit, and there are
> a large number of Linux distros that exhibit this problem.
>
> Signed-off-by: Gary Grebus <ggrebus@virtualiron.com>
>
>   

Could you please include a comment to this effect in the code?

Regards,

Anthony Liguori