From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L2Wjk-0003n1-1H
	for qemu-devel@nongnu.org; Tue, 18 Nov 2008 14:59:48 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L2Wji-0003mX-ID
	for qemu-devel@nongnu.org; Tue, 18 Nov 2008 14:59:47 -0500
Received: from [199.232.76.173] (port=43230 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L2Wji-0003mP-7m
	for qemu-devel@nongnu.org; Tue, 18 Nov 2008 14:59:46 -0500
Received: from wa-out-1112.google.com ([209.85.146.179]:57952)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1L2Wjh-0005ht-Uv
	for qemu-devel@nongnu.org; Tue, 18 Nov 2008 14:59:46 -0500
Received: by wa-out-1112.google.com with SMTP id j5so4237044wah.18
	for <qemu-devel@nongnu.org>; Tue, 18 Nov 2008 11:59:44 -0800 (PST)
Message-ID: <49231EAB.1080900@codemonkey.ws>
Date: Tue, 18 Nov 2008 13:59:39 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v5 04/18] Refactor and enhance
	break/watchpoint API
References: <20081117161857.26880.45423.stgit@mchn012c.ww002.siemens.net>
	<20081117161858.26880.37073.stgit@mchn012c.ww002.siemens.net>
In-Reply-To: <20081117161858.26880.37073.stgit@mchn012c.ww002.siemens.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Jan Kiszka wrote:
> This patch prepares the QEMU cpu_watchpoint/breakpoint API to allow the
> succeeding enhancements this series comes with.
>
> First of all, it overcomes MAX_BREAKPOINTS/MAX_WATCHPOINTS by switching
> to dynamically allocated data structures that are kept in linked lists.
> This also allows to return a stable reference to the related objects,
> required for later introduced x86 debug register support.
>
> Breakpoints and watchpoints are stored with their full information set
> and an additional flag field that makes them easily extensible for use
> beyond pure guest debugging.
>
> Finally, this restructuring lays the foundation for KVM to hook into
> the debugging infrastructure, providing its own services where hardware
> virtualization demands it. Once QEMUAccel is considered for merge,
> those entry point should be included into its abstraction layer so that
> accellerators can hook in even more cleanly.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>   

I noticed you use an open coded doubly linked list.  Can you submit a 
follow-up patch to convert the code to use a TAILQ from sys-queue.h?

Regards,

Anthony Liguori