From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L2Y0Y-0001tG-6f
	for qemu-devel@nongnu.org; Tue, 18 Nov 2008 16:21:14 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L2Y0V-0001s2-P6
	for qemu-devel@nongnu.org; Tue, 18 Nov 2008 16:21:13 -0500
Received: from [199.232.76.173] (port=57117 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L2Y0V-0001rw-E9
	for qemu-devel@nongnu.org; Tue, 18 Nov 2008 16:21:11 -0500
Received: from gv-out-0910.google.com ([216.239.58.190]:15611)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1L2Y0V-0004zx-IF
	for qemu-devel@nongnu.org; Tue, 18 Nov 2008 16:21:11 -0500
Received: by gv-out-0910.google.com with SMTP id n8so616294gve.36
	for <qemu-devel@nongnu.org>; Tue, 18 Nov 2008 13:21:09 -0800 (PST)
Message-ID: <492331C0.5030304@codemonkey.ws>
Date: Tue, 18 Nov 2008 15:21:04 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v5 18/18] gdbstub: x86: Switch 64/32 bit
	registers dynamically
References: <20081117161857.26880.45423.stgit@mchn012c.ww002.siemens.net>
	<20081117161859.26880.70678.stgit@mchn012c.ww002.siemens.net>
In-Reply-To: <20081117161859.26880.70678.stgit@mchn012c.ww002.siemens.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Jan Kiszka wrote:
> Commit 5459 broke gdbstub's dynamic register set switching between
> x86-64 and i386. That prevents setting the correct architecture in gdb
> when debugging 32 or 16-bit code in a 64-bit emulator. This patch
> reintroduces the feature over previous refactorings.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>   

This patch looks good to me.  If you resubmit against SVN, I'll apply 
it.  It is rejected right now because it depends on the previous patches 
and I didn't want to manually fix the rejects.

Regards,

Anthony Liguori